Skip to content

Make sure innerRadius is not NaN value#2631

Open
arnsvel wants to merge 1 commit intoc3js:masterfrom
arnsvel:master
Open

Make sure innerRadius is not NaN value#2631
arnsvel wants to merge 1 commit intoc3js:masterfrom
arnsvel:master

Conversation

@arnsvel
Copy link
Copy Markdown

@arnsvel arnsvel commented Jun 13, 2019

Error: attribute dx: Expected length, "NaNpx".
Replication:
Happens every time lost focus from/to browser tab when gauge chart is dynamically generated.

Investigation:
w = config.gauge_width is has assigned value 10
$$.innerRadiusRatio is -Infinity
$$.innerRadius is NaN

Error: attribute dx: Expected length, "NaNpx".
Replication:
Happens every time lost focus from/to browser tab when gauge chart is dynamically generated.

Investigation:
w = config.gauge_width is has assigned value 10
$$.innerRadiusRatio is -Infinity
$$.innerRadius is NaN
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2631 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2631      +/-   ##
==========================================
+ Coverage   80.15%   80.16%   +<.01%     
==========================================
  Files          57       57              
  Lines        4516     4517       +1     
==========================================
+ Hits         3620     3621       +1     
  Misses        896      896
Impacted Files Coverage Δ
src/arc.js 74.04% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c361534...b65ad6d. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 13, 2019

Codecov Report

Merging #2631 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2631      +/-   ##
==========================================
+ Coverage   80.15%   80.16%   +<.01%     
==========================================
  Files          57       57              
  Lines        4516     4517       +1     
==========================================
+ Hits         3620     3621       +1     
  Misses        896      896
Impacted Files Coverage Δ
src/arc.js 74.04% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c361534...b65ad6d. Read the comment docs.

Copy link
Copy Markdown
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this! one comment.

Comment thread src/arc.js
.remove();


$$.innerRadius = $$.innerRadius || 0;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not a right place to do this. How about checking this in updateRadius?

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.16%. Comparing base (c361534) to head (b65ad6d).
⚠️ Report is 168 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2631   +/-   ##
=======================================
  Coverage   80.15%   80.16%           
=======================================
  Files          57       57           
  Lines        4516     4517    +1     
=======================================
+ Hits         3620     3621    +1     
  Misses        896      896           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants