Make sure innerRadius is not NaN value#2631
Conversation
Error: attribute dx: Expected length, "NaNpx". Replication: Happens every time lost focus from/to browser tab when gauge chart is dynamically generated. Investigation: w = config.gauge_width is has assigned value 10 $$.innerRadiusRatio is -Infinity $$.innerRadius is NaN
Codecov Report
@@ Coverage Diff @@
## master #2631 +/- ##
==========================================
+ Coverage 80.15% 80.16% +<.01%
==========================================
Files 57 57
Lines 4516 4517 +1
==========================================
+ Hits 3620 3621 +1
Misses 896 896
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2631 +/- ##
==========================================
+ Coverage 80.15% 80.16% +<.01%
==========================================
Files 57 57
Lines 4516 4517 +1
==========================================
+ Hits 3620 3621 +1
Misses 896 896
Continue to review full report at Codecov.
|
kt3k
left a comment
There was a problem hiding this comment.
Thank you for looking into this! one comment.
| .remove(); | ||
|
|
||
|
|
||
| $$.innerRadius = $$.innerRadius || 0; |
There was a problem hiding this comment.
I think this is not a right place to do this. How about checking this in updateRadius?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2631 +/- ##
=======================================
Coverage 80.15% 80.16%
=======================================
Files 57 57
Lines 4516 4517 +1
=======================================
+ Hits 3620 3621 +1
Misses 896 896 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Error: attribute dx: Expected length, "NaNpx".
Replication:
Happens every time lost focus from/to browser tab when gauge chart is dynamically generated.
Investigation:
w = config.gauge_width is has assigned value 10
$$.innerRadiusRatio is -Infinity
$$.innerRadius is NaN