fix(flash): Check for I/O failure during firmware file reading

JakubVanek · JakubVanek · commit 2f5216ff68ba · 2025-06-21T01:34:55.000+02:00
diff --git a/src/bl_install.c b/src/bl_install.c
@@ -261,9 +261,11 @@ static int bootloader_send(FILE *fp, int length, u32* pCrc32)
 int bootloader_crc(FILE *fp, u32 starting_sector, u32 num_sectors, bool verbose)
 {
 	u8 *firmware = calloc(FLASH_SIZE, 1);
-	int read_bytes = fread(firmware, 1, FLASH_SIZE, fp);
-	if (read_bytes != FLASH_SIZE) {
-		printf("WARNING: firmware file might be truncated: %d bytes expected, %d bytes read\n", FLASH_SIZE, read_bytes);
+	fread(firmware, 1, FLASH_SIZE, fp);
+	if (ferror(fp)) {
+		errmsg = "Reading of firmware file failed";
+		free(firmware);
+		return ERR_IO;
 	}
 
 	int err = ERR_UNK;

Original file line number	Diff line number	Diff line change
`@@ -261,9 +261,11 @@ static int bootloader_send(FILE fp, int length, u32 pCrc32)`
`261`	`261`	`int bootloader_crc(FILE *fp, u32 starting_sector, u32 num_sectors, bool verbose)`
`262`	`262`	`{`
`263`	`263`	`u8 *firmware = calloc(FLASH_SIZE, 1);`
`264`		`- int read_bytes = fread(firmware, 1, FLASH_SIZE, fp);`
`265`		`- if (read_bytes != FLASH_SIZE) {`
`266`		`- printf("WARNING: firmware file might be truncated: %d bytes expected, %d bytes read\n", FLASH_SIZE, read_bytes);`
	`264`	`+ fread(firmware, 1, FLASH_SIZE, fp);`
	`265`	`+ if (ferror(fp)) {`
	`266`	`+ errmsg = "Reading of firmware file failed";`
	`267`	`+ free(firmware);`
	`268`	`+ return ERR_IO;`
`267`	`269`	`}`
`268`	`270`
`269`	`271`	`int err = ERR_UNK;`