feat: processor engines get http-nu's context-free commands (.mj etc.)#48
Open
cablehead wants to merge 2 commits into
Open
feat: processor engines get http-nu's context-free commands (.mj etc.)#48cablehead wants to merge 2 commits into
cablehead wants to merge 2 commits into
Conversation
14e0b4d to
b460336
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hand the xs processors (actor, service, action) a base engine with http-nu's
.mj,.md, and highlight commands, so they work in a service or actor, not just an HTTP handler.Engine::add_processor_commands(&store): store-backed.mj/.mj compile,.mj render,.md,.highlight*.Store::initsets this base before the processors spawn;prepared_baseclones it per spawn.Why
.mjwas registered only on the HTTP engine, so using it in a service failed. Model: xs ADR 0007.Notes
with_base_engine).cross-streamtemporarily tracks the xsfeat/engine-basebranch; revert to a release once #144 lands.Engine::newsplit: main's is already clean (the server job lives onwww-next-gen; the split applies there if that is the target).test_processor_base_command_surface. Lib suite green (85).test_eval_with_pluginfails only for a missingnu_plugin_testbinary (environmental).