⚡ Bolt: Optimize selection mutations to batch UI updates#139
⚡ Bolt: Optimize selection mutations to batch UI updates#139
Conversation
Batch element updates via `.map` to prevent multiple UI re-renders instead of mutating individually inside `for` loops. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Replaced individual
forloop mutations of the@PublishedarraysscanResultsandnodeModulesItemswith batched.mapassignments inCacheoutViewModel.swift. Added comments to explain the performance optimization. Also created.jules/bolt.mddocumenting this finding.🎯 Why
In SwiftUI, when a
@Publishedproperty holds an array of value types (like structs), mutating any element of that array triggers the property'swillSetobserver. Doing this inside a loop triggers a separate UI update notification (objectWillChange) for every single iteration, causing massive unnecessary CPU overhead and UI re-evaluation.📊 Impact
Reduces UI update notifications during bulk selection actions ("Select All", "Deselect All", etc.) from O(N) to exactly 1, vastly improving responsiveness when handling hundreds or thousands of cached items or node_modules folders.
🔬 Measurement
Verify by triggering a bulk action (e.g. "Select All") on a scan with a large number of results; the UI freeze and CPU spike previously associated with the O(N) updates should be eliminated.
PR created automatically by Jules for task 715615417954354689 started by @acebytes