Skip to content

🎨 Palette: Expand clickable area for category rows#140

Open
acebytes wants to merge 1 commit intomainfrom
palette/expand-category-row-hit-area-2651412343508475026
Open

🎨 Palette: Expand clickable area for category rows#140
acebytes wants to merge 1 commit intomainfrom
palette/expand-category-row-hit-area-2651412343508475026

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

💡 What:

  • Wrapped the entire CategoryRow's HStack contents inside a single Button.
  • Applied .contentShape(Rectangle()) so empty space is clickable.
  • Maintained existing styling by using .buttonStyle(.plain).
  • Grouped VoiceOver elements via .accessibilityElement(children: .combine).
  • Replaced the nested checkbox button with an Image tied to the row button's action.

🎯 Why:
Previously, users had to click the tiny checkbox icon to select or deselect a category. Expanding the hit area to the entire row makes the interaction significantly more pleasant and forgiving.

📸 Before/After:
Visually identical, but the entire row now reacts to taps/clicks instead of just the leading icon.

♿ Accessibility:
By combining the row elements, VoiceOver now reads the category name, size, risk level, and its selection state cohesively in a single sweep instead of fragmenting it into multiple separate focus elements.


PR created automatically by Jules for task 2651412343508475026 started by @acebytes

Wrapped the entire CategoryRow HStack in a Button to expand the hit area beyond just the checkbox, significantly improving the UX and interaction target size. Applied `contentShape(Rectangle())` so that whitespace clicks register. In addition, combined VoiceOver elements using `.accessibilityElement(children: .combine)` and added appropriate selection traits.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant