🛡️ Sentinel: [Security Enhancement] Secure toolExists shell execution#141
🛡️ Sentinel: [Security Enhancement] Secure toolExists shell execution#141
Conversation
…hell wrapper string interpolation vulnerability in `toolExists` with a secure, native `Process` execution using the `/usr/bin/which` executable and an arguments array. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0414170d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| process.executableURL = URL(fileURLWithPath: "/usr/bin/which") | ||
| process.arguments = [tool] |
There was a problem hiding this comment.
toolExists now invokes /usr/bin/which with the inherited process environment, but the previous implementation used shell() which set a deterministic PATH including /opt/homebrew/bin and /usr/local/bin. In app launches without a full shell PATH (common for GUI contexts), checks for tools like brew, npm, or uv will incorrectly fail; then resolvedPaths short-circuits on requiresTool and skips fallback paths entirely, so these cache categories disappear from scan results. Set process.environment here (or remove the pre-check gate) to retain previous behavior.
Useful? React with 👍 / 👎.
1 participant
💡 What: Refactored
toolExistsinSources/Cacheout/Models/CacheCategory.swiftto use directFoundation.Processexecution instead of a shell wrapper.\n\n🎯 Why: Eliminates command injection risk as a defense-in-depth measure by avoiding string interpolation of thetoolvariable into a bash-ccommand string.\n\n✅ Verification: Verified through manual inspection; unit tests were unavailable in the sandbox but code cleanly utilizes nativeProcessexecution.PR created automatically by Jules for task 3692088120069987798 started by @acebytes