Conversation
Avoid string interpolation in shell command wrappers. Used Foundation.Process directly to evaluate /usr/bin/which status, eliminating a potential command injection vector as part of a defense-in-depth security approach. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95af424837
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let process = Process() | ||
| process.executableURL = URL(fileURLWithPath: "/usr/bin/which") | ||
| process.arguments = [tool] | ||
| process.standardOutput = FileHandle.nullDevice | ||
| process.standardError = FileHandle.nullDevice |
There was a problem hiding this comment.
This refactor drops the explicit PATH that shell() previously set (/opt/homebrew/bin:/usr/local/bin:...), so which now inherits the app process environment. When the app is launched from Finder (or any context with a minimal PATH), toolExists("brew")/toolExists("npm") can return false even when those tools are installed in Homebrew locations, which causes resolvedPaths to continue before probe/fallback handling and makes entire cache categories disappear from scanning.
Useful? React with 👍 / 👎.
1 participant
💡 What: Refactored the
toolExistsmethod inCacheCategory.swiftto useFoundation.Processnatively rather than passing string-interpolated arguments to ashellwrapper function.🎯 Why: This prevents any potential command injection vulnerabilities. Even though the current invocations pass static strings (like
"npm"), using string interpolation in bash contexts (shell("/usr/bin/which \(tool)")) is an unsafe pattern. Passing dynamic inputs strictly as elements inProcess().argumentsensures the shell cannot misinterpret them as executable commands, reinforcing the app's defense-in-depth posture.PR created automatically by Jules for task 15384512853714418527 started by @acebytes