Conversation
Replaced `shell()` with direct `Process` execution to prevent command injection vulnerabilities via string interpolation. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f33d14a3d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let process = Process() | ||
| process.executableURL = URL(fileURLWithPath: "/usr/bin/which") | ||
| process.arguments = [tool] | ||
| process.standardOutput = FileHandle.nullDevice | ||
| process.standardError = FileHandle.nullDevice |
There was a problem hiding this comment.
This refactor changed toolExists to inherit the app’s environment, but Finder/LaunchServices-launched macOS apps often have a minimal PATH (commonly missing /opt/homebrew/bin and /usr/local/bin). In that context, /usr/bin/which brew/npm/pnpm returns not found even when the tool is installed, so .probed(... requiresTool: ...) categories are skipped and cache locations are never discovered. The previous implementation avoided this by forcing a known PATH via shell().
Useful? React with 👍 / 👎.
1 participant
💡 What: Refactored
toolExiststo use directProcessexecution instead of interpolating strings inshell()wrapper commands.🎯 Why: This is a defense-in-depth measure to mitigate command injection risks by avoiding shell wrapper commands with string interpolation or variables. Instead, use
Process().argumentsarray to separate the executable and its arguments.PR created automatically by Jules for task 64058303321218979 started by @acebytes