Skip to content

⚡ Bolt: [batch UI updates for selection methods]#147

Open
acebytes wants to merge 1 commit intomainfrom
bolt-swiftui-published-map-optimization-4761531457861173439
Open

⚡ Bolt: [batch UI updates for selection methods]#147
acebytes wants to merge 1 commit intomainfrom
bolt-swiftui-published-map-optimization-4761531457861173439

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

💡 What
Replaced for loop mutations of @Published properties (scanResults and nodeModulesItems) with functional .map reassignments in CacheoutViewModel.

🎯 Why
Mutating individual elements of a @Published array property inside a loop triggers objectWillChange and a subsequent UI rendering pass on every single iteration. This leads to an O(N) number of UI updates, which can block the main thread and cause sluggishness when selecting/deselecting multiple items (like during "Smart Clean").

📊 Impact
Reduces UI rendering passes for bulk selection/deselection operations from O(N) to O(1). This completely eliminates main-thread blocking when processing dozens or hundreds of discovered cache paths or node_modules directories.

🔬 Measurement
Run the app, perform a scan that yields a high number of node modules or cache paths, and toggle "Select All" or "Smart Clean". The UI response should be instantaneous compared to potentially stuttering before.

(A journal entry was also added to .jules/bolt.md documenting this SwiftUI performance edge-case.)


PR created automatically by Jules for task 4761531457861173439 started by @acebytes

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant