⚡ Bolt: Optimize @Published array mutations to reduce UI re-renders#148
⚡ Bolt: Optimize @Published array mutations to reduce UI re-renders#148
Conversation
Refactored `CacheoutViewModel` array updates to batch `@Published` Combine notifications. Replaced `for` loop mutations of the `scanResults` and `nodeModulesItems` arrays with functional `.map` reassignments to ensure only a single UI update is triggered per bulk operation. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Replaced array loop mutations with
.mapreassignments for@Publishedproperties inCacheoutViewModel(e.g.,selectAllSafe,deselectAll,selectAllNodeModules).🎯 Why: Mutating individual array elements in an
@ObservableObjectusing a loop triggers a UI Combine publisher emission (objectWillChange) for every single element, causing massive performance degradation during bulk selection.📊 Impact: Significantly reduces UI re-renders from O(N) to O(1) per bulk action, making 'Select All' and 'Deselect All' operations lightning fast.
🔬 Measurement: Observe UI responsiveness and CPU profile when selecting/deselecting large lists of cache items.
PR created automatically by Jules for task 8976709613515587309 started by @acebytes