Skip to content

πŸ›‘οΈ Sentinel: Fix pipe buffer deadlock causing DoS in process execution#150

Open
acebytes wants to merge 1 commit intomainfrom
sentinel/pipe-deadlock-fix-15521284356069803461
Open

πŸ›‘οΈ Sentinel: Fix pipe buffer deadlock causing DoS in process execution#150
acebytes wants to merge 1 commit intomainfrom
sentinel/pipe-deadlock-fix-15521284356069803461

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

🚨 Severity: HIGH
πŸ’‘ Vulnerability: A Denial of Service (DoS) vulnerability existed when using Foundation.Process to execute shell commands because the parent process called process.waitUntilExit() before fully reading the child's standard output pipe. If the child process output exceeded the OS pipe buffer limit (typically 64KB), the child would block writing to the full pipe while the parent blocked waiting for the child to exit, causing the application to hang indefinitely.
🎯 Impact: A local attacker or simply an application state producing large command output could freeze the Cacheout application or daemon, preventing subsequent cache operations or monitoring tasks.
πŸ”§ Fix: Reordered the calls to consume the pipe output (readDataToEndOfFile()) before or concurrently with waitUntilExit() in CacheCategory.swift and CacheoutViewModel.swift, adhering to safe Process execution practices.
βœ… Verification: Verified that Foundation.Process invocations correctly read output before calling waitUntilExit(). Test script executed to confirm the syntax and structure are preserved.


PR created automatically by Jules for task 15521284356069803461 started by @acebytes

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant