Skip to content

⚡ Bolt: Reuse expensive DateFormatter and ByteCountFormatter instances#151

Open
acebytes wants to merge 1 commit intomainfrom
bolt/formatter-optimization-17412456081582868883
Open

⚡ Bolt: Reuse expensive DateFormatter and ByteCountFormatter instances#151
acebytes wants to merge 1 commit intomainfrom
bolt/formatter-optimization-17412456081582868883

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

💡 What: Extracted ByteCountFormatter and ISO8601DateFormatter into a centralized, static Formatters enum.
🎯 Why: Instantiating DateFormatter, ISO8601DateFormatter, and relying on class methods for ByteCountFormatter in Foundation is computationally expensive. Reusing statically allocated instances avoids the overhead of repeated allocations in high-frequency formatting methods across views, view models, and CLI output logic.
📊 Impact: Reduces computational overhead and improves execution performance when formatting sizes and dates.
🔬 Measurement: Verify changes with codebase tests and standard code review; ensure all formatted strings (sizes and timestamps) display identically to their previous states.


PR created automatically by Jules for task 17412456081582868883 started by @acebytes

…nces

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af7f2ccdbd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


enum Formatters {
// Cached statically for performance to avoid expensive allocations during high-frequency formatting
static let byteCount: ByteCountFormatter = {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid shared non-Sendable formatter singletons

Formatters.byteCount (and similarly Formatters.iso8601) introduces mutable Foundation formatter instances as global static state in Sources/Cacheout/Models/Formatters.swift, which are non-Sendable and trigger strict-concurrency MutableGlobalVariable diagnostics (an error in Swift 6 mode). This also creates a real cross-actor access path because formatting now happens from both @MainActor code in CacheoutViewModel and cleaner-actor code in CacheCleaner.logCleanup, so the shared instance can be touched concurrently. The previous per-call/class-method usage avoided this shared mutable state; please confine formatter instances to a single actor/context or guard access with synchronization.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant