🎨 Palette: Improve list row clickability and VoiceOver experience#153
🎨 Palette: Improve list row clickability and VoiceOver experience#153
Conversation
Wrapped `CategoryRow` and `NodeModulesRow` `HStack`s in a `Button` with `.contentShape(Rectangle())` to make the entire row clickable. Added `.accessibilityElement(children: .combine)` and `.accessibilityAddTraits(.isSelected)` to improve the VoiceOver reading experience by presenting the row as a single cohesive element. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Wrapped entire list rows (
CategoryRowandNodeModulesRow) in Buttons and addedcontentShape(Rectangle()).🎯 Why: Isolated checkboxes provided small hit targets and poor grouping for VoiceOver.
📸 Before/After: Visual hit target expanded to the entire row.
♿ Accessibility: Added combine children and isSelected traits so VoiceOver reads the row state and contents correctly.
PR created automatically by Jules for task 6764981684795056985 started by @acebytes