Skip to content

⚡ Bolt: Optimize collection evaluations in CacheoutViewModel#403

Closed
acebytes wants to merge 1 commit into
mainfrom
bolt/optimize-cacheoutviewmodel-collections-8117351289559932857
Closed

⚡ Bolt: Optimize collection evaluations in CacheoutViewModel#403
acebytes wants to merge 1 commit into
mainfrom
bolt/optimize-cacheoutviewmodel-collections-8117351289559932857

Conversation

@acebytes

Copy link
Copy Markdown
Contributor

💡 What: Replaced eager array evaluations (!selectedResults.isEmpty and selectedNodeModulesSize > 0) with short-circuiting .contains(where:), and updated selectedSize to use .lazy.filter.
🎯 Why: Checking .isEmpty on a .filter result or > 0 on a .reduce result forces O(N) traversal and intermediate array allocations. .contains(where:) short-circuits at the first match.
📊 Impact: Reduces memory allocations and CPU overhead during UI updates when checking hasSelection and selectedSize across large result lists.
🔬 Measurement: Profile CacheoutViewModel property accesses during item selection in Instruments; the computed property execution time and memory allocations should be noticeably lower.


PR created automatically by Jules for task 8117351289559932857 started by @acebytes

Replaced eager array evaluations (!selectedResults.isEmpty and
selectedNodeModulesSize > 0) with short-circuiting .contains(where:).
Updated selectedSize to use .lazy.filter to prevent intermediate
array allocations when reducing.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@acebytes

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of canonical #404.

#404 makes both selectedSize use scanResults.lazy.filter AND hasSelection use contains(where:) on both scanResults and nodeModulesItems — full short-circuit on both arrays. The two PRs differ from #404 only by keypath idiom (#404 uses \.isSelected, slightly cleaner) and (for #399) by leaving hasSelection still calling selectedNodeModulesSize > 0, which forces a full reduce of nodeModulesItems to check for existence.

@acebytes acebytes closed this Jun 17, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing as duplicate of canonical #404.

#404 makes both selectedSize use scanResults.lazy.filter AND hasSelection use contains(where:) on both scanResults and nodeModulesItems — full short-circuit on both arrays. The two PRs differ from #404 only by keypath idiom (#404 uses \.isSelected, slightly cleaner) and (for #399) by leaving hasSelection still calling selectedNodeModulesSize > 0, which forces a full reduce of nodeModulesItems to check for existence.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant