Skip to content

🎨 Palette: Add accessibility elements grouping to metric components#411

Closed
acebytes wants to merge 1 commit into
mainfrom
palette/stat-grouping-2898370938387995059
Closed

🎨 Palette: Add accessibility elements grouping to metric components#411
acebytes wants to merge 1 commit into
mainfrom
palette/stat-grouping-2898370938387995059

Conversation

@acebytes

Copy link
Copy Markdown
Contributor

💡 What: Added .accessibilityElement(children: .combine) to the statPill component in MenuBarView and to the DiskUsageBar container.
🎯 Why: To ensure VoiceOver reads stat groups (labels + values) cohesively in a single swipe, rather than as fragmented disjointed text pieces.
📸 Before/After: Visuals unchanged, VoiceOver experience improved.
♿ Accessibility: Groups the separated text components so VoiceOver announces the entire block at once, improving the user experience for visually impaired users.


PR created automatically by Jules for task 2898370938387995059 started by @acebytes

…omponent in `MenuBarView` and to the `DiskUsageBar` container to ensure VoiceOver reads stat groups cohesively.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@acebytes

Copy link
Copy Markdown
Contributor Author

Closing as a strict subset of canonical #409, which adds the same .accessibilityElement(children: .combine) modifier to MenuBarView.swift AND also covers DiskUsageBar.swift in the same PR.

@acebytes acebytes closed this Jun 19, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing as a strict subset of canonical #409, which adds the same .accessibilityElement(children: .combine) modifier to MenuBarView.swift AND also covers DiskUsageBar.swift in the same PR.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant