🎨 Palette: Add .accessibilityElement(children: .combine) to emptyState in ContentView.swift#429
🎨 Palette: Add .accessibilityElement(children: .combine) to emptyState in ContentView.swift#429acebytes wants to merge 1 commit into
.accessibilityElement(children: .combine) to emptyState in ContentView.swift#429Conversation
Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5507bbabd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .foregroundStyle(.tertiary) | ||
| Spacer() | ||
| } | ||
| .accessibilityElement(children: .combine) |
There was a problem hiding this comment.
Because this combined empty-state VStack starts with the decorative Image(systemName: "magnifyingglass"), SwiftUI derives the new parent accessibility label from all accessible children, so VoiceOver can announce the symbol name together with the two text strings (for example, “magnifying glass, Click Scan…”). In this empty-state scenario, that makes the single announcement noisier rather than just reading the guidance; hide the image from accessibility or give the combined element an explicit label that contains only the text.
Useful? React with 👍 / 👎.
1 participant
💡 What: Added
.accessibilityElement(children: .combine)to theemptyStateview'sVStackinContentView.swift.🎯 Why: VoiceOver reads empty state views (like an icon and text) as disjointed fragments if they aren't combined. This ensures VoiceOver announces the empty state as a single unified message.
📸 Before/After: No visual change.
♿ Accessibility: The empty state is now announced as a single cohesive statement to screen reader users instead of multiple separate elements.
PR created automatically by Jules for task 13908830214895675375 started by @acebytes