Run shellcheck on installation hook tests#528
Open
nicknovitski wants to merge 1 commit intocachix:masterfrom
Open
Run shellcheck on installation hook tests#528nicknovitski wants to merge 1 commit intocachix:masterfrom
nicknovitski wants to merge 1 commit intocachix:masterfrom
Conversation
Contributor
Author
|
Rebased on master. I've also run the flake checks on |
Contributor
Author
|
Rebased and tested again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the way the tests are written, this also runs shellcheck on each test derivation's shellHook, which gets a lot of coverage of the shellHooks in general.
Besides the obvious bash-level fixes, some of the warnings and errors I fixed by moving the logic out into nix, which felt a lot simpler.