Open
Conversation
sandydoo
requested changes
Sep 15, 2025
Member
sandydoo
left a comment
sandydoo
left a comment
There was a problem hiding this comment.
Looks good! Only missing the upgrade story for configPath.
| type = types.submodule { | ||
| imports = [ hookModule ]; | ||
| options.settings = { | ||
| configPath = mkOption { |
Member
There was a problem hiding this comment.
configPath should be deprecated and added to config-files to allow people to migrate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of "checking" if formatting is correct, cmake-format should format the files with
--in-place.