fix: Propagate ECH keys to the QUIC listener#7670
Merged
Conversation
mholt
approved these changes
Apr 23, 2026
Member
mholt
left a comment
There was a problem hiding this comment.
Huh, thanks. Makes sense I guess!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Touches a small follow-up to #7653.
Summary
This preserves ECH handling on the QUIC / HTTP/3 path by forwarding
GetEncryptedClientHelloKeysthrough Caddy's shared QUIC TLS config.#7653 fixes the HTTPS RR
alpnomission but that was only part of the problem. Found in #7667, QUIC was still rebuilding a minimal TLS config withGetConfigForClientonly which meant the HTTP/3 listener could not process ECH even though the normal TLS path could.This change keeps the existing shared-config model for QUIC listeners and adds the missing ECH key callback so the QUIC path sees the same ECH-capable behaviour as the TCP TLS path.
Tests
Added a listener regression test to verify:
Should close #7667.
Assistance Disclosure
No AI was used.