Preserve DNS provider metadata for DNS-01 cleanup#382
Merged
mholt merged 1 commit intoMay 12, 2026
Conversation
mholt
approved these changes
May 12, 2026
Member
mholt
left a comment
There was a problem hiding this comment.
Fair enough, didn't realize ProviderData was that useful, but this makes sense! Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change stores the full
libdns.Recordreturned byAppendRecordswhile a DNS-01 challenge is active, instead of reducing it torecord.RR()immediately.The portable DNS fields are still accessed through
record.RR()for propagation checks, logging, and memory lookup. Cleanup now passes the original returned record back toDeleteRecords, preserving provider-specific metadata such asProviderData.Why
Some libdns providers receive an internal record ID from the provider API when creating a record and store it in
ProviderData. If CertMagic discards that metadata, cleanup may need to list zone records and rediscover the provider ID before deletion.Preserving the returned record is more robust:
Record.RR().This does not make CertMagic depend on provider-specific IDs. It only avoids discarding metadata when a provider supplies it.
Validation
Added a regression unit test verifying that cleanup receives the original returned record including
ProviderData.Tested with:
go test ./...Fixes #381