fix(cli): tunnel moc exit code so compiler crashes are distinguishable#605
Merged
Conversation
moc exit code so compiler crashes are distinguishable
Contributor
Cursor AI review👍 APPROVE — looks safe to merge
VerdictDecision: APPROVE Generated for commit 06526ba |
ggreif
approved these changes
Jun 30, 2026
ggreif
left a comment
Contributor
There was a problem hiding this comment.
Looks solid to me and an important feature to have!
moc exits 2 on a compiler crash vs 1 for user errors. Route final moc failures through cliExit(code) instead of cliError (always 1). mops test tracks moc crash codes via pipeMMF's onClose callback and exits 2 when any moc process crashed during the run. Co-authored-by: Cursor <cursoragent@cursor.com>
39a44da to
06526ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mops build,mops check,mops generate,mops check-stable, andmops testnow exit withmoc's process exit code instead of always1. CLI output is unchanged — use$?to tell a compiler crash (2) from a normal user error (1).Why
mocexits1for user errors (type/compile errors, stable-compat mismatch, bad args) and2for compiler crashes (uncaught internal error). mops routed everymocfailure throughcliError, which hard-codesprocess.exit(1), so a crash looked like any other failure in CI or retry loops.Before / After
What is unchanged
cliError(exit1) for config/validation/IO errors; only finalmocfailure sites usecliExit(code, …).--fix),mops watch,mops bench.