Add pt hf trainer#203
Open
gkumbhat wants to merge 141 commits into
Open
Conversation
9cdbace to
3bfd53c
Compare
Collaborator
Author
|
Thoughts on TODOs on the PR:
|
88020a7 to
4106ba7
Compare
Collaborator
Author
Some preliminary tests to be done before merging
Notes
|
Collaborator
Author
Notes from testingTest parameters
HF Trainer branchTime:
Main branch, No HF Trainer branch
HF Trainer branch
Main branch, No HF Trainer branch
HF Trainer branch
Multi-gpu testing (2 A100-80G)HF Trainer branch
|
this avoids printing a deprecation warning Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
…tion Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
…text_func "OTHER" is an invalid value for caikit.interfaces.nlp.data_model.text_generation.FinishReason, resulting in failed serialization of responses when querying the text generation endpoint. For `generate_text_func`, it is reasonable to assume that if the finish reason is not `EOS_TOKEN` or `STOP_SEQUENCE`, it must be `MAX_TOKENS`. Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
… configuration Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
fixes caikit#245 Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
… defaults Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com> Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
- add install subsection - add model serving subsection - cleanup docker section - add configuration subsection Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
ed63133 to
45e6c18
Compare
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #175
Changes
random_seedto prompt tuning training APINotes
dataset_type.from_generatorconverted doesn't accept empty dataset and raises error. For this reason, I had to modifytrain_streamin test and make them not emptyEvaluation
Prompt Tuning:
Fine tuning
TODO
infer_stepsfunction, since its currently not doing it the same waytrainerwould do, i.e not considering gradient checkpointing 🤔