Skip to content

Commit b7cce0d

Browse files
cailmdaleyclaude
andcommitted
refactor: scrub stale /actions + ActionsController comment refs
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016RVNkdUCoxqgGVVhUoApVp
1 parent e4cf72b commit b7cce0d

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

lib/shuttle/lifecycle_service.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ defmodule Shuttle.LifecycleService do
44
awaiting role by writing the felt document (`accept` / `resume`).
55
66
Both the `/api/v1/lifecycle` endpoint (operator / shuttle-ctl) and the
7-
`/api/v1/actions/invoke` kanban path go through here, so an accept behaves
7+
`/api/v1/transition` kanban path go through here, so an accept behaves
88
identically regardless of which gesture triggered it. The work is:
99
1010
1. Run the transition *through the Poller* (`Poller.lifecycle_transition/3`)

lib/shuttle/poller.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3059,7 +3059,7 @@ defmodule Shuttle.Poller do
30593059
# command, the host directory it ran in, the exit status, and trimmed
30603060
# stderr. felt's own stderr for a nonexistent store can be empty (it just
30613061
# finds no index), which previously bubbled up as a BLANK `{:error, ""}` →
3062-
# an undiagnosable 500 at the ActionsController boundary. Including the host
3062+
# an undiagnosable 500 at the HTTP boundary. Including the host
30633063
# path names the actual fault — typically a felt-store path that doesn't
30643064
# exist on this machine (a foreign absolute path registered by another
30653065
# host's portolan).

lib/shuttle/transition.ex

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ defmodule Shuttle.Transition do
3232
relayed response's `origin`. Terminating in one hop: a fiber has exactly
3333
one owner, and the owner never re-forwards.
3434
35-
Both this service's `/transition` endpoint and the legacy `/actions/invoke`
36-
endpoint share `invoke/2` and `http_error/1`, so the invoke pipeline and its
35+
This service's `/transition` endpoint uses `invoke/2` and `http_error/1`, so the invoke pipeline and its
3736
status mapping have a single implementation.
3837
"""
3938

@@ -92,7 +91,7 @@ defmodule Shuttle.Transition do
9291

9392
@doc """
9493
The invoke pipeline: validate the action id, confirm it is available for the
95-
fiber right now, then perform the mutation. Shared with `/actions/invoke`.
94+
fiber right now, then perform the mutation.
9695
"""
9796
@spec invoke(String.t(), String.t()) :: :ok | {:error, term()}
9897
def invoke(fiber_id, action) do

0 commit comments

Comments
 (0)