ImpersonationService: remove unused return value

petergeneric · petergeneric · commit f448a877fa3a · 2026-04-13T23:52:19.000+01:00
diff --git a/user-manager/service/src/main/java/com/peterphi/usermanager/guice/authentication/ImpersonationService.java b/user-manager/service/src/main/java/com/peterphi/usermanager/guice/authentication/ImpersonationService.java
@@ -27,7 +27,7 @@ public class ImpersonationService
 	public boolean enabled = true;
 
 	@AuthConstraint(id = "impersonation", role = UserLogin.ROLE_ADMIN, comment = "only admins can impersonate other users")
-	public String impersonate(final int userId)
+	public void impersonate(final int userId)
 	{
 		if (!enabled)
 			throw new IllegalArgumentException(
@@ -43,7 +43,5 @@ public String impersonate(final int userId)
 		         newUser.getEmail());
 
 		currentUser.reload(newUser);
-
-		return newUser.getSessionReconnectKey();
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public class ImpersonationService`
`27`	`27`	`public boolean enabled = true;`
`28`	`28`
`29`	`29`	`@AuthConstraint(id = "impersonation", role = UserLogin.ROLE_ADMIN, comment = "only admins can impersonate other users")`
`30`		`- public String impersonate(final int userId)`
	`30`	`+ public void impersonate(final int userId)`
`31`	`31`	`{`
`32`	`32`	`if (!enabled)`
`33`	`33`	`throw new IllegalArgumentException(`
`@@ -43,7 +43,5 @@ public String impersonate(final int userId)`
`43`	`43`	`newUser.getEmail());`
`44`	`44`
`45`	`45`	`currentUser.reload(newUser);`
`46`		`-`
`47`		`- return newUser.getSessionReconnectKey();`
`48`	`46`	`}`
`49`	`47`	`}`