v1.1.3 - fix locked roles

When a user edited the roles through the Customizations UI, it was setting all Teams roles to is_editable:0, making them all locked. This was because the plugin wasn't overriding the roles in the filter to get roles.

Removed the checks to see if the roles already exist so that they get overridden with the expected value (undefined) for is_editable. Customized permissions still get set in a lower priority filter.

Author: cairocoder01

disciple-tools-team-module.php

@@ -5,7 +5,7 @@
  * Description: The Team Module adds a way to access and share contacts and groups in a collaborative team setting.
  * Text Domain: disciple-tools-team-module
  * Domain Path: /languages
- * Version:  1.1.2
+ * Version:  1.1.3
  * Author URI: https://github.com/cairocoder01
  * GitHub Plugin URI: https://github.com/cairocoder01/disciple-tools-team-module
  * Requires at least: 4.7.0

post-type/module-base.php

@@ -106,51 +106,43 @@ public function dt_set_roles_and_permissions( $expected_roles ){
             'update_any_trainings' => true,
         ), $base_team_member_permissions );
 
-        if ( !isset( $expected_roles['team_member'] ) ){
-            $expected_roles['team_member'] = array(
-                'label' => __( 'Team Member', 'disciple-tools-team-module' ),
-                'description' => 'Interacts with Contacts, Groups, etc., for a given team',
-                'permissions' => $base_team_member_permissions,
-            );
-        }
-
-        if ( !isset( $expected_roles['team_collaborator'] ) ){
-            $expected_roles['team_collaborator'] = array(
-                'label' => __( 'Team Collaborator', 'disciple-tools-team-module' ),
-                'description' => 'Access to all Contacts, Groups, etc. for all teams',
-                'permissions' => wp_parse_args( array(), $general_all_teams_permissions ),
-                'order' => 20,
-            );
-        }
-
-        if ( !isset( $expected_roles['team_leader'] ) ){
-            $expected_roles['team_leader'] = array(
-                'label' => __( 'Team Leader', 'disciple-tools-team-module' ),
-                'description' => 'Access to all Contacts, Groups, etc. for all teams and access to update their team',
-                'permissions' => wp_parse_args( array(
-                    'access_teams' => true,
-                    'view_any_teams' => true,
-                    'update_my_teams' => true,
-                ), $general_all_teams_permissions ),
-                'order' => 20,
-            );
-        }
-
-        if ( !isset( $expected_roles['teams_admin'] ) ) {
-            $expected_roles['teams_admin'] = array(
-                'label' => __( 'Teams Admin', 'disciple-tools-team-module' ),
-                'description' => 'Admin access to all teams',
-                'permissions' => wp_parse_args( array(
-                    'view_project_metrics' => true,
-
-                    'access_teams' => true,
-                    'create_teams' => true,
-                    'view_any_teams' => true,
-                    'update_any_teams' => true,
-                ), $general_all_teams_permissions ),
-                'order' => 20,
-            );
-        }
+        $expected_roles['team_member'] = array(
+            'label' => __( 'Team Member', 'disciple-tools-team-module' ),
+            'description' => 'Interacts with Contacts, Groups, etc., for a given team',
+            'permissions' => $base_team_member_permissions,
+        );
+
+        $expected_roles['team_collaborator'] = array(
+            'label' => __( 'Team Collaborator', 'disciple-tools-team-module' ),
+            'description' => 'Access to all Contacts, Groups, etc. for all teams',
+            'permissions' => wp_parse_args( array(), $general_all_teams_permissions ),
+            'order' => 20,
+        );
+
+        $expected_roles['team_leader'] = array(
+            'label' => __( 'Team Leader', 'disciple-tools-team-module' ),
+            'description' => 'Access to all Contacts, Groups, etc. for all teams and access to update their team',
+            'permissions' => wp_parse_args( array(
+                'access_teams' => true,
+                'view_any_teams' => true,
+                'update_my_teams' => true,
+            ), $general_all_teams_permissions ),
+            'order' => 20,
+        );
+
+        $expected_roles['teams_admin'] = array(
+            'label' => __( 'Teams Admin', 'disciple-tools-team-module' ),
+            'description' => 'Admin access to all teams',
+            'permissions' => wp_parse_args( array(
+                'view_project_metrics' => true,
+
+                'access_teams' => true,
+                'create_teams' => true,
+                'view_any_teams' => true,
+                'update_any_teams' => true,
+            ), $general_all_teams_permissions ),
+            'order' => 20,
+        );
 
 
         // Only admins can view/update the teams post type

version-control.json

@@ -1,7 +1,7 @@
 {
   "name": "Disciple.Tools - Team Module",
-  "version": "1.1.2",
-  "last_updated": "2025-07-30",
+  "version": "1.1.3",
+  "last_updated": "2025-08-14",
   "author": "cairocoder01",
   "author_homepage": "https://github.com/cairocoder01",
   "git_owner": "cairocoder01",