fix(io): tolerate broken symlinks when cleaning directories#4801
Conversation
Skip recursion into child directories that do not exist (e.g. broken symlinks such as macOS framework Versions/Current) and remove the link entry instead of failing the clean operation. Fixes cake-build#2135
|
@leno23 Before we can review this PR, Contributor License Agreement(CLA) needs to be signed. |
|
@leno23 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
Summary
Fixes #2135
CleanDirectory/CleanDirectoriescould fail on macOS when a directory tree contains broken symbolic links (e.g.Versions/Currentin a.frameworkbundle pointing to a missing target).This PR:
DirectoryNotFoundException/IOExceptionduring child cleanup and deletes the symlink entry when appropriateTest plan
DirectoryCleanerSymlinkTests.Should_Clean_Directory_Containing_Broken_Symlink_On_Unix(skipped on Windows)Cake.Common.TestsI do not have a local .NET SDK in this environment; tests were not executed locally.
Made with Cursor