fix(dotnet): resolve DotNetVSTest paths from WorkingDirectory (#1917)#4817
fix(dotnet): resolve DotNetVSTest paths from WorkingDirectory (#1917)#4817leno23 wants to merge 1 commit into
Conversation
…uild#1917) Relative Settings, TestAdapterPath, DiagnosticFile, and ResultsDirectory are now resolved against ToolSettings.WorkingDirectory when set.
|
@leno23 Before we can review this PR, Contributor License Agreement(CLA) needs to be signed. |
|
@leno23 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
Summary
Related to #1917.
When
DotNetVSTestSettings.WorkingDirectoryis set, relative paths for vstest settings were still resolved against the Cake script directory. They are now resolved againstWorkingDirectory:Settings(runsettings file)TestAdapterPathDiagnosticFileResultsDirectoryAdds shared
GetAbsoluteDirectoryPath/GetAbsoluteFilePathhelpers onDotNetTool.Complements #4810–#4816.
Test plan
Should_Resolve_VSTest_Paths_Relative_To_WorkingDirectoryCake.Common.Tests(no local .NET SDK; relying on GitHub Actions)Made with Cursor