Skip to content

fix: monero address display in tx history#3249

Merged
OmarHatem28 merged 4 commits into
devfrom
CW-1489-Fix-address-displayin-tx-history
May 26, 2026
Merged

fix: monero address display in tx history#3249
OmarHatem28 merged 4 commits into
devfrom
CW-1489-Fix-address-displayin-tx-history

Conversation

@Blazebrain

Copy link
Copy Markdown
Contributor

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed

@Blazebrain Blazebrain requested a review from OmarHatem28 May 22, 2026 05:24
@Blazebrain Blazebrain self-assigned this May 22, 2026
@Blazebrain Blazebrain marked this pull request as ready for review May 22, 2026 05:24
@OmarHatem28 OmarHatem28 requested a review from malik1004x May 24, 2026 21:57
@OmarHatem28

OmarHatem28 commented May 25, 2026

Copy link
Copy Markdown
Contributor

@Blazebrain why are we returning the account with the address and then regex it, I am confused
CC @malik1004x if this is something intended please elaborate

@malik1004x

Copy link
Copy Markdown
Contributor

This appears correct – it's a fix for the backend returning the address together with the label as one string. You could also do this inside the Monero module, but then it could potentially have some side effects.

@OmarHatem28 OmarHatem28 merged commit f3de4b2 into dev May 26, 2026
6 checks passed
@OmarHatem28 OmarHatem28 deleted the CW-1489-Fix-address-displayin-tx-history branch May 26, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants