add-lints#3356
Open
malik1004x wants to merge 48 commits into
Open
Conversation
# Conflicts: # lib/new-ui/pages/card_customizer.dart # tool/generate_localization.dart
This reverts commit 4869f0b.
OmarHatem28
reviewed
Jul 6, 2026
OmarHatem28
left a comment
OmarHatem28
left a comment
Contributor
There was a problem hiding this comment.
@MrCyjaneK please review it as well and see if anything I missed or can be improved
| @@ -1,4 +1,3 @@ | |||
| include: package:lints/recommended.yaml | |||
Contributor
There was a problem hiding this comment.
I believe removing this does remove some important ones as well.
I verified with Claude, and it said some of them are not included in the list you added.
like:
- null_check_on_nullable_type_parameter
- null_closures
- exhaustive_cases
- depend_on_referenced_packages
- no_wildcard_variable_uses
- prefer_interpolation_to_compose_strings
those are the ones that I see would be good from the list claude gave, but feel free to add others if you see fit.
or I would say, since we already had lints/recommended.yaml, why not keep it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): Fixes #
Description
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist