Skip to content

fix: show Zcash transparent address metadata#3371

Open
Arbeitszeit wants to merge 1 commit into
cake-tech:devfrom
Arbeitszeit:fix/zcash-transparent-address-metadata
Open

fix: show Zcash transparent address metadata#3371
Arbeitszeit wants to merge 1 commit into
cake-tech:devfrom
Arbeitszeit:fix/zcash-transparent-address-metadata

Conversation

@Arbeitszeit

Copy link
Copy Markdown

Issue Number (if Applicable): N/A

Description

This change provides real transaction-count and balance metadata for rotated Zcash transparent addresses instead of displaying null, while preserving address labels across refreshes.

Changes

  • Fix rotated-account lookup to use the integer account ID rather than a seed string as a map key.
  • Track transparent balance and transaction count for each rotated account using the existing Warp API data.
  • Associate address-list entries with their actual rotated account IDs.
  • Refresh address metadata during wallet balance updates.
  • Preserve user labels when the transparent address list is rebuilt.
  • Allow Zcash transparent address labels to be edited and persisted.
  • Include transparent funds in the wallet's frozen balance until they are shielded, so deposits remain visible without being treated as immediately spendable.
  • Recognize rotated addresses in containsAddress().

Validation

  • git diff --check passes.
  • Runtime validation with restored and existing Zcash wallets is still required. The Flutter/native build toolchain was not available in the analysis environment.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant