feat: generate Zcash transparent addresses on demand#3372
Draft
Arbeitszeit wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): N/A
Description
This is an experimental, stacked proposal that adds on-demand generation of disposable Zcash transparent addresses.
It currently depends on #3371. The branch includes that PR's metadata commit and should be rebased after #3371 is merged.
Design
Cake Wallet already derives disposable transparent addresses by creating indexed accounts from its offset-seed scheme. This proposal exposes creation of the next indexed account through the receive-page rotation button.
To keep seed recovery deterministic:
The UI awaits generation, prevents duplicate button presses, selects the newly generated address, and displays generation or gap-limit errors in a snackbar.
Open review questions
Validation required
Only
git diff --checkwas available locally. Native Zcash and device testing must be completed before this draft is considered merge-ready.Pull Request - Checklist