address reviews

Author: josbeir

.github/workflows/docs-validation-reusable.yml

@@ -4,15 +4,10 @@ on:
   workflow_call:
     inputs:
       docs-path:
-        description: 'Path to the docs directory (e.g. "docs/")'
+        description: 'Path to the docs directory (e.g. "docs")'
         required: false
         type: string
-        default: 'docs/'
-      markdown-glob:
-        description: 'Glob pattern for markdown files'
-        required: false
-        type: string
-        default: 'docs/**/*.md'
+        default: 'docs'
       enable-toc-check:
         description: 'Enable TOC link validation (requires .vitepress/toc_*.json)'
         required: false
@@ -86,7 +81,13 @@ jobs:
 
       - name: Validate JSON syntax
         run: |
-          for file in .vitepress/toc_*.json; do
+          shopt -s nullglob
+          files=(.vitepress/toc_*.json)
+          if [ ${#files[@]} -eq 0 ]; then
+            echo "No .vitepress/toc_*.json files found"
+            exit 1
+          fi
+          for file in "${files[@]}"; do
             if ! jq empty "$file" 2>/dev/null; then
               echo "Invalid JSON: $file"
               exit 1
@@ -135,8 +136,13 @@ jobs:
       - name: Determine config path
         id: config
         run: |
-          if [ -n "${{ inputs.markdownlint-config }}" ] && [ -f "${{ inputs.markdownlint-config }}" ]; then
-            echo "path=${{ inputs.markdownlint-config }}" >> $GITHUB_OUTPUT
+          if [ -n "${{ inputs.markdownlint-config }}" ]; then
+            if [ -f "${{ inputs.markdownlint-config }}" ]; then
+              echo "path=${{ inputs.markdownlint-config }}" >> $GITHUB_OUTPUT
+            else
+              echo "Error: markdownlint config '${{ inputs.markdownlint-config }}' does not exist." >&2
+              exit 1
+            fi
           else
             echo "path=.docs-tools/.github/.markdownlint-cli2.jsonc" >> $GITHUB_OUTPUT
           fi
@@ -145,7 +151,7 @@ jobs:
         uses: DavidAnson/markdownlint-cli2-action@v23
         with:
           config: ${{ steps.config.outputs.path }}
-          globs: ${{ inputs.markdown-glob }}
+          globs: '${{ inputs.docs-path }}/**/*.md'
 
   spell-check:
     name: Spell Check
@@ -167,16 +173,21 @@ jobs:
       - name: Determine config path
         id: config
         run: |
-          if [ -n "${{ inputs.cspell-config }}" ] && [ -f "${{ inputs.cspell-config }}" ]; then
-            echo "path=${{ inputs.cspell-config }}" >> $GITHUB_OUTPUT
+          if [ -n "${{ inputs.cspell-config }}" ]; then
+            if [ -f "${{ inputs.cspell-config }}" ]; then
+              echo "path=${{ inputs.cspell-config }}" >> $GITHUB_OUTPUT
+            else
+              echo "Error: cspell config '${{ inputs.cspell-config }}' does not exist." >&2
+              exit 1
+            fi
           else
             echo "path=.docs-tools/.github/cspell.json" >> $GITHUB_OUTPUT
           fi
 
       - name: Check spelling
         uses: streetsidesoftware/cspell-action@v8
         with:
-          files: ${{ inputs.markdown-glob }}
+          files: '${{ inputs.docs-path }}/**/*.md'
           config: ${{ steps.config.outputs.path }}
           incremental_files_only: true
 
@@ -202,19 +213,25 @@ jobs:
       - name: Get changed markdown files
         id: changed-files
         run: |
+          DOCS_PATH="${{ inputs.docs-path }}"
           if [ "${{ github.event_name }}" == "pull_request" ]; then
-            FILES=$(git diff --name-only --diff-filter=d origin/${{ github.base_ref }}...HEAD | grep '\.md$' || true)
+            BASE_SHA="${{ github.event.pull_request.base.sha }}"
+            if [ -z "$BASE_SHA" ]; then
+              git fetch origin "${{ github.base_ref }}" --depth=1 2>/dev/null || true
+              BASE_SHA="origin/${{ github.base_ref }}"
+            fi
+            FILES=$(git diff --name-only --diff-filter=d "${BASE_SHA}"...HEAD | grep "^${DOCS_PATH}/.*\.md$" || true)
             if [ -z "$FILES" ]; then
-              echo "No markdown files changed"
+              echo "No markdown files changed in ${DOCS_PATH}/"
               echo "files=" >> $GITHUB_OUTPUT
             else
               echo "files=$(echo $FILES | tr '\n' ' ')" >> $GITHUB_OUTPUT
               echo "Checking files:"
               echo "$FILES"
             fi
           else
-            echo "files=${{ inputs.markdown-glob }}" >> $GITHUB_OUTPUT
-            echo "Checking all files: ${{ inputs.markdown-glob }}"
+            echo "files=${DOCS_PATH}/**/*.md" >> $GITHUB_OUTPUT
+            echo "Checking all files: ${DOCS_PATH}/**/*.md"
           fi
 
       - name: Check internal links

.github/workflows/docs-validation.yml

@@ -23,6 +23,7 @@ jobs:
     # TODO: Change back to @5.x after merging this PR
     uses: cakephp/docs/.github/workflows/docs-validation-reusable.yml@reusable-validation-workflow
     with:
+      docs-path: 'docs'
       enable-config-js-check: true
       enable-json-lint: true
       enable-toc-check: true