Conversation
|
Refs #1068 Small issue: SqliteAdapter silently ignores the registration The PR puts $specificColumnTypes + addSpecificColumnType() on AbstractAdapter, implying universal support. But I checked all four adapters' getColumnTypes():
So SqliteAdapter::addSpecificColumnType('foo') writes to AbstractAdapter::$specificColumnTypes (via LSB, since Sqlite doesn't redeclare it) and then isValidColumnType() never consults that list. Silent no-op on Sqlite. Either fix Sqlite to also merge, or keep the API Postgres/MySQL/SqlServer-only and document that. |
|
Should also target 5.next |
|
Gap: no reset / removal API static::$specificColumnTypes[] mutates a class-static array with no teardown. The bundled test registers 'my_custom_type' and
Worth adding removeSpecificColumnType(string) and/or resetSpecificColumnTypes() — five lines plus a tearDown clearing them. Gap: the test doesn't live where it ought to testAddColumnWithSpecificColumnType is in tests/TestCase/Db/Table/TableTest.php, which makes sense as a general-machinery |
Allow addition of specific adapter column type.