cleanup CS

Author: LordSimal

.gitignore

@@ -5,7 +5,6 @@
 /tags
 /composer.lock
 /phpunit.xml
-/phpcs.xml
 /tools
 /vendor
 *.mo
@@ -16,6 +15,7 @@ error.log
 /tests/test_app/config/TestsQueue/schema-dump-test.lock
 /tests/test_app/Plugin/TestBlog/config/Queue/*
 .phpunit.cache
+.phpcs.cache
 
 # IDE and editor specific files #
 #################################

composer.json

@@ -60,8 +60,8 @@
             "@cs-check",
             "@test"
         ],
-        "cs-check": "phpcs --colors -p src/ tests/",
-        "cs-fix": "phpcbf --colors -p src/ tests/",
+        "cs-check": "phpcs",
+        "cs-fix": "phpcbf",
         "stan": "@phpstan",
         "phpstan": "tools/phpstan analyse",
         "stan-baseline": "tools/phpstan --generate-baseline",

phpcs.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0"?>
+<ruleset name="CakePHP PluginInstaller">
+    <file>src/</file>
+    <file>tests/</file>
+    <rule ref="CakePHP" />
+    <arg value="nps"/>
+    <arg name="colors"/>
+    <arg name="parallel" value="4"/>
+    <arg name="cache" value=".phpcs.cache"/>
+
+    <exclude-pattern>tests/comparisons/*</exclude-pattern>
+</ruleset>

src/Job/SendMailJob.php

@@ -38,7 +38,6 @@ public function execute(Message $message): ?string
         try {
             $transportClassName = $message->getArgument('transport');
             $config = $message->getArgument('config', []);
-            /** @var \Cake\Mailer\AbstractTransport $transport */
             $transport = $this->getTransport($transportClassName, $config);
 
             $emailMessage = new MailerMessage();

tests/TestCase/Queue/ProcessorTest.php

@@ -30,7 +30,6 @@
 use PHPUnit\Framework\Attributes\DataProvider;
 use TestApp\TestProcessor;
 use TestApp\WelcomeMailer;
-use Traversable;
 
 class ProcessorTest extends TestCase
 {
@@ -47,21 +46,8 @@ class ProcessorTest extends TestCase
      */
     protected function eventListToArray(EventList $events): array
     {
-        if ($events instanceof Traversable) {
-            /** @var array<\Cake\Event\EventInterface> */
-            return iterator_to_array($events);
-        }
-
-        $result = [];
-        $count = $events->count();
-        for ($i = 0; $i < $count; $i++) {
-            $event = $events[$i];
-            if ($event !== null) {
-                $result[] = $event;
-            }
-        }
-
-        return $result;
+        /** @var array<\Cake\Event\EventInterface> */
+        return iterator_to_array($events);
     }
 
     /**