fix: address Cubic Dev AI P2 review issues

- Use Promise.all for parallel email invites (Issue 1)
- Use i18n.language instead of hardcoded "en" (Issue 2)
- Notify users about invalid emails instead of silently dropping (Issue 3)
- Use opt.email instead of opt.label for deduplication (Issue 4)

Author: Claude Assistant

apps/web/modules/event-types/components/AddMembersWithSwitch.tsx

@@ -82,7 +82,7 @@ const CheckedHostField = ({
   teamId?: number;
   allowEmailInvites?: boolean;
 } & Omit<Partial<ComponentProps<typeof CheckedTeamSelect>>, "onChange" | "value">) => {
-  const { t } = useLocale();
+  const { t, i18n } = useLocale();
   const inviteMutation = trpc.viewer.teams.inviteMember.useMutation();
 
   // Handle inviting new members by email
@@ -92,28 +92,30 @@ const CheckedHostField = ({
         return { success: [], failed: emails };
       }
 
-      const success: string[] = [];
-      const failed: string[] = [];
+      // Process invites in parallel for better performance
+      const results = await Promise.all(
+        emails.map(async (email) => {
+          try {
+            await inviteMutation.mutateAsync({
+              teamId,
+              usernameOrEmail: email,
+              role: MembershipRole.MEMBER,
+              language: i18n.language,
+              creationSource: CreationSource.WEBAPP,
+            });
+            return { email, success: true };
+          } catch (error) {
+            return { email, success: false };
+          }
+        })
+      );
 
-      // Invite each email
-      for (const email of emails) {
-        try {
-          await inviteMutation.mutateAsync({
-            teamId,
-            usernameOrEmail: email,
-            role: MembershipRole.MEMBER,
-            language: "en",
-            creationSource: CreationSource.WEBAPP,
-          });
-          success.push(email);
-        } catch (error) {
-          failed.push(email);
-        }
-      }
+      const success = results.filter((r) => r.success).map((r) => r.email);
+      const failed = results.filter((r) => !r.success).map((r) => r.email);
 
       return { success, failed };
     },
-    [teamId, inviteMutation]
+    [teamId, inviteMutation, i18n.language]
   );
 
   return (

packages/features/eventtypes/components/CheckedTeamSelect.tsx

@@ -73,11 +73,24 @@ const isValidEmail = (email: string): boolean => {
 };
 
 // Parse pasted text for multiple emails
-const parsePastedEmails = (text: string): string[] => {
-  return text
+const parsePastedEmails = (text: string): { valid: string[]; invalid: string[] } => {
+  const tokens = text
     .split(/[,;\n\r\s]+/)
     .map((email) => email.trim().toLowerCase())
-    .filter((email) => email.length > 0 && isValidEmail(email));
+    .filter((email) => email.length > 0);
+  
+  const valid: string[] = [];
+  const invalid: string[] = [];
+  
+  for (const email of tokens) {
+    if (isValidEmail(email)) {
+      valid.push(email);
+    } else {
+      invalid.push(email);
+    }
+  }
+  
+  return { valid, invalid };
 };
 
 export const CheckedTeamSelect = ({
@@ -117,14 +130,19 @@ export const CheckedTeamSelect = ({
     async (inputValue: string) => {
       if (!allowEmailInvites || !onEmailInvite) return;
 
-      const emails = parsePastedEmails(inputValue);
-      if (emails.length === 0) {
+      const { valid: emails, invalid: invalidEmails } = parsePastedEmails(inputValue);
+
+      // Notify user about invalid emails
+      if (invalidEmails.length > 0) {
         showToast(t("invalid_email_format"), "error");
+      }
+
+      if (emails.length === 0) {
         return;
       }
 
-      // Check which emails are already in options (by checking if label matches email)
-      const existingEmails = new Set(options.map((opt) => opt.label?.toLowerCase()).filter(Boolean));
+      // Check which emails are already in options (by checking if email matches)
+      const existingEmails = new Set(options.map((opt) => opt.email?.toLowerCase()).filter(Boolean));
       const newEmails = emails.filter((email) => !existingEmails.has(email));
 
       if (newEmails.length === 0) {
@@ -165,11 +183,16 @@ export const CheckedTeamSelect = ({
       if (!allowEmailInvites) return;
 
       const pastedText = event.clipboardData.getData("text");
-      const emails = parsePastedEmails(pastedText);
+      const { valid: emails, invalid: invalidEmails } = parsePastedEmails(pastedText);
+
+      // Notify user about invalid emails
+      if (invalidEmails.length > 0) {
+        showToast(t("invalid_email_format"), "error");
+      }
 
       // If we have multiple emails or a valid single email that's not in options, process it
       if (emails.length >= 1) {
-        const existingEmails = new Set(options.map((opt) => opt.label?.toLowerCase()).filter(Boolean));
+        const existingEmails = new Set(options.map((opt) => opt.email?.toLowerCase()).filter(Boolean));
         const newEmails = emails.filter((email) => !existingEmails.has(email));
 
         if (newEmails.length > 0 && onEmailInvite) {