feat: allow email invites in team event assignment (#13532)#28733
Open
omnialp wants to merge 2 commits intocalcom:mainfrom
Open
feat: allow email invites in team event assignment (#13532)#28733omnialp wants to merge 2 commits intocalcom:mainfrom
omnialp wants to merge 2 commits intocalcom:mainfrom
Conversation
- Add CreatableSelect support to CheckedTeamSelect for free-form email input - Implement email validation using emailSchema - Support bulk email paste (comma, semicolon, newline, space separated) - Integrate with existing inviteMember TRPC mutation - Add invitation status feedback via toast notifications - Enable email invites in EventTeamAssignmentTab for fixed and round-robin hosts - Add i18n translations for invitation feedback messages
Contributor
There was a problem hiding this comment.
4 issues found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/web/modules/event-types/components/AddMembersWithSwitch.tsx">
<violation number="1" location="apps/web/modules/event-types/components/AddMembersWithSwitch.tsx:101">
P2: Bulk email invites are processed sequentially via `await` in a loop, causing avoidable latency and slow UX for large pasted invite lists.</violation>
<violation number="2" location="apps/web/modules/event-types/components/AddMembersWithSwitch.tsx:105">
P2: New email-invite path hardcodes `language: "en"`, causing invite localization to ignore the active user locale.</violation>
</file>
<file name="packages/features/eventtypes/components/CheckedTeamSelect.tsx">
<violation number="1" location="packages/features/eventtypes/components/CheckedTeamSelect.tsx:80">
P2: Bulk paste silently drops invalid email tokens without notifying users, leading to unclear partial invite outcomes.</violation>
<violation number="2" location="packages/features/eventtypes/components/CheckedTeamSelect.tsx:127">
P2: Existing-member email dedupe incorrectly keys on display label, so already-member emails may be re-invited and user feedback becomes inaccurate.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
apps/web/modules/event-types/components/AddMembersWithSwitch.tsx
Outdated
Show resolved
Hide resolved
apps/web/modules/event-types/components/AddMembersWithSwitch.tsx
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/web/modules/event-types/components/AddMembersWithSwitch.tsx">
<violation number="1" location="apps/web/modules/event-types/components/AddMembersWithSwitch.tsx:96">
P2: Bulk email invites are dispatched with unbounded parallel requests, increasing rate-limit/throttling failures for large pasted batches.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
apps/web/modules/event-types/components/AddMembersWithSwitch.tsx
Outdated
Show resolved
Hide resolved
- Replace sequential processing with batch-based parallel processing - Limit concurrency to 3 concurrent requests per batch - Resolves P2 issue: unbounded parallel requests causing rate-limit failures Fixes review comment from cubic-dev-ai on PR calcom#28733
e96293a to
99dd49f
Compare
Author
|
All P2 issues have been addressed:
Commit: CLA has been signed as well. Please re-run the review when you get a chance. Thanks! |
Contributor
@omnialp I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the feature requested in #13532: Allow inviting team members by email address directly from the event type assignment UI.
Changes
How it works
Technical details
Fixes #13532