fix: Cal Video fails to load in Firefox with Enhanced Tracking Protection#28714
fix: Cal Video fails to load in Firefox with Enhanced Tracking Protection#28714sudoKrishna wants to merge 7 commits into
Conversation
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
There was a problem hiding this comment.
3 issues found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".env.example">
<violation number="1" location=".env.example:74">
P1: Hardcoded default secrets in .env.example create shared credentials for deployments that copy the defaults, undermining auth/session signing and encryption.</violation>
</file>
<file name="apps/web/modules/videos/views/videos-single-view.tsx">
<violation number="1" location="apps/web/modules/videos/views/videos-single-view.tsx:156">
P1: Failure timeout is unconditional and not cancelled on successful call join, so it can incorrectly switch UI to `videoFailed` after 8s.</violation>
<violation number="2" location="apps/web/modules/videos/views/videos-single-view.tsx:189">
P2: Failure fallback UI can render without destroying the active Daily call, potentially leaking background media/session resources.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
|
Hi @calcom/foundation Could a maintainer please approve the workflows to run? This PR fixes #28473 where Firefox users with Enhanced Tracking Protection see an infinite loading screen instead of joining the video call. All review issues |
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
Fixes #28473
Issue
Cal Video fails to load in Firefox when Enhanced Tracking Protection is enabled.
Users see an infinite loading screen.
Fix
Testing