feat: Add UTM parameter as an additional filter option for bookings#28759
Closed
deepshekhardas wants to merge 1 commit into
Closed
feat: Add UTM parameter as an additional filter option for bookings#28759deepshekhardas wants to merge 1 commit into
deepshekhardas wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/web/modules/bookings/columns/filterColumns.ts">
<violation number="1" location="apps/web/modules/bookings/columns/filterColumns.ts:27">
P2: New UTM filters are added to column metadata but not wired into filter extraction/query input, so selecting them will not actually filter booking results.</violation>
<violation number="2" location="apps/web/modules/bookings/columns/filterColumns.ts:138">
P2: New UTM translation keys are used in filter headers but are missing from locale files, risking raw key text in the UI.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| }), | ||
| columnHelper.accessor((row) => (row.type === "data" ? row.booking.utmSource : null), { | ||
| id: "utmSource", | ||
| header: t("utm_source"), |
Contributor
There was a problem hiding this comment.
P2: New UTM translation keys are used in filter headers but are missing from locale files, risking raw key text in the UI.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/modules/bookings/columns/filterColumns.ts, line 138:
<comment>New UTM translation keys are used in filter headers but are missing from locale files, risking raw key text in the UI.</comment>
<file context>
@@ -128,5 +133,64 @@ export function buildFilterColumns({ t, permissions, status }: BuildFilterColumn
}),
+ columnHelper.accessor((row) => (row.type === "data" ? row.booking.utmSource : null), {
+ id: "utmSource",
+ header: t("utm_source"),
+ enableColumnFilter: true,
+ enableSorting: false,
</file context>
| "attendeeEmail", | ||
| "dateRange", | ||
| "bookingUid", | ||
| "utmSource", |
Contributor
There was a problem hiding this comment.
P2: New UTM filters are added to column metadata but not wired into filter extraction/query input, so selecting them will not actually filter booking results.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/modules/bookings/columns/filterColumns.ts, line 27:
<comment>New UTM filters are added to column metadata but not wired into filter extraction/query input, so selecting them will not actually filter booking results.</comment>
<file context>
@@ -24,6 +24,11 @@ const FILTER_COLUMN_IDS = [
"attendeeEmail",
"dateRange",
"bookingUid",
+ "utmSource",
+ "utmMedium",
+ "utmCampaign",
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28717
Summary
Adds UTM parameter filters to the bookings data table, allowing users to filter bookings by UTM source, medium, campaign, term, and content.
Changes
Benefits
Testing