Skip to content

feat: Add UTM parameter as an additional filter option for bookings #28759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deepshekhardas wants to merge 1 commit into from
Closed

feat: Add UTM parameter as an additional filter option for bookings #28759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 65 additions & 1 deletion apps/web/modules/bookings/columns/filterColumns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ const FILTER_COLUMN_IDS = [
"attendeeEmail",
"dateRange",
"bookingUid",
"utmSource",
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot Apr 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: New UTM filters are added to column metadata but not wired into filter extraction/query input, so selecting them will not actually filter booking results.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/modules/bookings/columns/filterColumns.ts, line 27:

<comment>New UTM filters are added to column metadata but not wired into filter extraction/query input, so selecting them will not actually filter booking results.</comment>

<file context>
@@ -24,6 +24,11 @@ const FILTER_COLUMN_IDS = [
   "attendeeEmail",
   "dateRange",
   "bookingUid",
+  "utmSource",
+  "utmMedium",
+  "utmCampaign",
</file context>
Fix with Cubic

"utmMedium",
"utmCampaign",
"utmTerm",
"utmContent",
] as const;

/**
Expand Down Expand Up @@ -128,5 +133,64 @@ export function buildFilterColumns({ t, permissions, status }: BuildFilterColumn
},
},
}),
columnHelper.accessor((row) => (row.type === "data" ? row.booking.utmSource : null), {
id: "utmSource",
header: t("utm_source"),
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot Apr 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: New UTM translation keys are used in filter headers but are missing from locale files, risking raw key text in the UI.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/modules/bookings/columns/filterColumns.ts, line 138:

<comment>New UTM translation keys are used in filter headers but are missing from locale files, risking raw key text in the UI.</comment>

<file context>
@@ -128,5 +133,64 @@ export function buildFilterColumns({ t, permissions, status }: BuildFilterColumn
     }),
+    columnHelper.accessor((row) => (row.type === "data" ? row.booking.utmSource : null), {
+      id: "utmSource",
+      header: t("utm_source"),
+      enableColumnFilter: true,
+      enableSorting: false,
</file context>
Fix with Cubic

enableColumnFilter: true,
enableSorting: false,
cell: () => null,
meta: {
filter: {
type: ColumnFilterType.TEXT,
},
},
}),
columnHelper.accessor((row) => (row.type === "data" ? row.booking.utmMedium : null), {
id: "utmMedium",
header: t("utm_medium"),
enableColumnFilter: true,
enableSorting: false,
cell: () => null,
meta: {
filter: {
type: ColumnFilterType.TEXT,
},
},
}),
columnHelper.accessor((row) => (row.type === "data" ? row.booking.utmCampaign : null), {
id: "utmCampaign",
header: t("utm_campaign"),
enableColumnFilter: true,
enableSorting: false,
cell: () => null,
meta: {
filter: {
type: ColumnFilterType.TEXT,
},
},
}),
columnHelper.accessor((row) => (row.type === "data" ? row.booking.utmTerm : null), {
id: "utmTerm",
header: t("utm_term"),
enableColumnFilter: true,
enableSorting: false,
cell: () => null,
meta: {
filter: {
type: ColumnFilterType.TEXT,
},
},
}),
columnHelper.accessor((row) => (row.type === "data" ? row.booking.utmContent : null), {
id: "utmContent",
header: t("utm_content"),
enableColumnFilter: true,
enableSorting: false,
cell: () => null,
meta: {
filter: {
type: ColumnFilterType.TEXT,
},
},
}),
];
}
Loading