Skip to content

cleanup(test): remove org admin event type integration coverage#29016

Merged
romitg2 merged 1 commit into
calcom:mainfrom
romitg2:cleanup/remove-org-admin-eventtype-integration-coverage
Apr 28, 2026
Merged

cleanup(test): remove org admin event type integration coverage#29016
romitg2 merged 1 commit into
calcom:mainfrom
romitg2:cleanup/remove-org-admin-eventtype-integration-coverage

Conversation

@romitg2
Copy link
Copy Markdown
Member

@romitg2 romitg2 commented Apr 26, 2026

What this does

  • removes organization-admin and team-access coverage from getEventTypeById.integration-test.ts
  • keeps the remaining regular-user event type access coverage intact

Verification

VITEST_MODE=integration yarn test packages/features/eventtypes/lib/getEventTypeById.integration-test.ts
yarn type-check:ci --force

Both commands passed locally.

@romitg2 romitg2 added ready-for-e2e run-ci Approve CI to run for external contributors labels Apr 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "cleanup" found in pull request title "cleanup(test): remove org admin event type integration coverage". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@romitg2 romitg2 marked this pull request as ready for review April 26, 2026 19:01
@romitg2 romitg2 enabled auto-merge (squash) April 26, 2026 19:01
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a1739319-5d5a-4696-b5e3-fd805dc89632

📥 Commits

Reviewing files that changed from the base of the PR and between 57586ba and 7775d10.

📒 Files selected for processing (1)
  • packages/features/eventtypes/lib/getEventTypeById.integration-test.ts
💤 Files with no reviewable changes (1)
  • packages/features/eventtypes/lib/getEventTypeById.integration-test.ts

📝 Walkthrough

Walkthrough

The integration test file for getEventTypeById is simplified to focus on regular user access scenarios. Test data builders and database cleanup logic related to organizations, teams, memberships, and profiles are removed. Test cases exercising organization admin behavior, platform admin scenarios, and cross-organization access checks are deleted. The createTestUser helper function no longer supports creating profiles through parameter overrides. The relational database setup associated with these removed features is eliminated, reducing the overall test file by 265 lines.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing organization admin event type integration test coverage from the file.
Description check ✅ Passed The description is directly related to the changeset, clearly explaining what was removed (org-admin and team-access coverage) and what was kept (regular-user coverage), with verification steps provided.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@romitg2 romitg2 requested a review from sahitya-chandra April 26, 2026 19:32
@romitg2 romitg2 merged commit de1ffb0 into calcom:main Apr 28, 2026
56 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-e2e run-ci Approve CI to run for external contributors size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants