Skip to content

cleanup(test): remove org booking integration coverage#29019

Merged
romitg2 merged 1 commit intocalcom:mainfrom
romitg2:cleanup/remove-org-booking-integration-coverage
Apr 28, 2026
Merged

cleanup(test): remove org booking integration coverage#29019
romitg2 merged 1 commit intocalcom:mainfrom
romitg2:cleanup/remove-org-booking-integration-coverage

Conversation

@romitg2
Copy link
Copy Markdown
Member

@romitg2 romitg2 commented Apr 26, 2026

What this does

  • removes the organization-scoped booking audit integration suites
  • removes organization watchlist coverage from spam-booking.integration-test.ts
  • keeps the remaining global watchlist spam-booking coverage intact

Verification

VITEST_MODE=integration yarn test packages/features/bookings/lib/handleNewBooking/test/spam-booking.integration-test.ts
yarn type-check:ci --force

Both commands passed locally.

@romitg2 romitg2 added ready-for-e2e run-ci Approve CI to run for external contributors labels Apr 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "cleanup" found in pull request title "cleanup(test): remove org booking integration coverage". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@romitg2 romitg2 marked this pull request as ready for review April 28, 2026 08:04
@romitg2 romitg2 enabled auto-merge (squash) April 28, 2026 08:04
@romitg2 romitg2 requested a review from sahitya-chandra April 28, 2026 08:04
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2ffa4608-43e5-4e8a-b488-31f8bf87e837

📥 Commits

Reviewing files that changed from the base of the PR and between 57586ba and cbfeb14.

📒 Files selected for processing (7)
  • packages/features/booking-audit/lib/service/__tests__/accepted-action.integration-test.ts
  • packages/features/booking-audit/lib/service/__tests__/attendee-added-action.integration-test.ts
  • packages/features/booking-audit/lib/service/__tests__/cancelled-action.integration-test.ts
  • packages/features/booking-audit/lib/service/__tests__/created-action.integration-test.ts
  • packages/features/booking-audit/lib/service/__tests__/location-changed-action.integration-test.ts
  • packages/features/booking-audit/lib/service/__tests__/no-show-updated-action.integration-test.ts
  • packages/features/bookings/lib/handleNewBooking/test/spam-booking.integration-test.ts
💤 Files with no reviewable changes (7)
  • packages/features/booking-audit/lib/service/tests/attendee-added-action.integration-test.ts
  • packages/features/booking-audit/lib/service/tests/cancelled-action.integration-test.ts
  • packages/features/booking-audit/lib/service/tests/accepted-action.integration-test.ts
  • packages/features/booking-audit/lib/service/tests/created-action.integration-test.ts
  • packages/features/booking-audit/lib/service/tests/no-show-updated-action.integration-test.ts
  • packages/features/bookings/lib/handleNewBooking/test/spam-booking.integration-test.ts
  • packages/features/booking-audit/lib/service/tests/location-changed-action.integration-test.ts

📝 Walkthrough

Walkthrough

This change removes integration test files and test cases from the booking-audit and bookings packages. Specifically, six integration test files in the booking-audit service are deleted entirely, removing test coverage for ACCEPTED, ATTENDEE_ADDED, CANCELLED, CREATED, LOCATION_CHANGED, and NO_SHOW_UPDATED booking actions. Additionally, organization watchlist-related integration tests are removed from the spam-booking test suite. These deletions eliminate approximately 1,356 lines of test code across the affected modules.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'cleanup(test): remove org booking integration coverage' directly summarizes the main change: removing organization-scoped booking integration tests.
Description check ✅ Passed The description clearly explains what was removed (org-scoped booking audit suites and org watchlist coverage) and what was preserved (global watchlist tests), directly relating to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@romitg2 romitg2 merged commit c2c95b3 into calcom:main Apr 28, 2026
56 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-e2e run-ci Approve CI to run for external contributors size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants