Skip to content

cleanup(workflows): remove dead workflow runtime config#29028

Merged
romitg2 merged 1 commit intocalcom:mainfrom
romitg2:cleanup/remove-dead-workflow-runtime-config
Apr 28, 2026
Merged

cleanup(workflows): remove dead workflow runtime config#29028
romitg2 merged 1 commit intocalcom:mainfrom
romitg2:cleanup/remove-dead-workflow-runtime-config

Conversation

@romitg2
Copy link
Copy Markdown
Member

@romitg2 romitg2 commented Apr 26, 2026

Summary

  • remove dead workflow function entries from apps/web/vercel.json
  • stop advertising non-existent workflow cron/trpc handlers in the Vercel runtime config

Verification

  • node -e 'JSON.parse(require("fs").readFileSync("apps/web/vercel.json","utf8")); console.log("vercel.json valid")'\n- verified these routes are absent:\n - apps/web/app/api/cron/workflows/scheduleEmailReminders/route.ts\n - apps/web/app/api/cron/workflows/scheduleSMSReminders/route.ts\n - apps/web/app/api/cron/workflows/scheduleWhatsappReminders/route.ts\n - apps/web/pages/api/trpc/workflows/[trpc].ts\n- yarn type-check:ci --force

@github-actions
Copy link
Copy Markdown
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "cleanup" found in pull request title "cleanup(workflows): remove dead workflow runtime config". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@romitg2 romitg2 added ready-for-e2e run-ci Approve CI to run for external contributors labels Apr 26, 2026
@romitg2 romitg2 marked this pull request as ready for review April 26, 2026 20:17
@romitg2 romitg2 enabled auto-merge (squash) April 26, 2026 20:17
@romitg2 romitg2 requested a review from sahitya-chandra April 26, 2026 20:17
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

📝 Walkthrough

Walkthrough

The Vercel configuration file (apps/web/vercel.json) has been modified to remove explicit timeout overrides. The maxDuration settings of 800 seconds that were previously applied to specific API routes (three cron workflow reminder endpoints and a TRPC workflow handler) have been removed. The functions configuration object is now empty, with no explicit duration overrides remaining for these routes.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing dead workflow runtime configuration from vercel.json.
Description check ✅ Passed The description is directly related to the changeset, explaining what dead entries were removed and providing specific verification steps performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
apps/web/vercel.json (1)

32-32: Optional: drop the empty functions object.

Since there are no per-function overrides left, the empty "functions": {} key can be removed entirely — Vercel will simply use defaults. Keeping an empty stanza is harmless but adds noise.

♻️ Proposed cleanup
-  ],
-  "functions": {}
+  ]
 }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@apps/web/vercel.json` at line 32, Remove the empty "functions": {} stanza
from the JSON so Vercel will use defaults; locate the apps/web vercel.json entry
containing the literal key "functions" with an empty object and delete that
key-value pair (no other changes required).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@apps/web/vercel.json`:
- Line 32: Remove the empty "functions": {} stanza from the JSON so Vercel will
use defaults; locate the apps/web vercel.json entry containing the literal key
"functions" with an empty object and delete that key-value pair (no other
changes required).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cc44a591-bf58-4271-a026-6e71328a1e6f

📥 Commits

Reviewing files that changed from the base of the PR and between 987fe91 and 84cb62a.

📒 Files selected for processing (1)
  • apps/web/vercel.json

@romitg2 romitg2 merged commit d2a54e2 into calcom:main Apr 28, 2026
56 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-e2e run-ci Approve CI to run for external contributors size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants