cleanup(workflows): remove dead workflow runtime config#29028
cleanup(workflows): remove dead workflow runtime config#29028romitg2 merged 1 commit intocalcom:mainfrom
Conversation
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
📝 WalkthroughWalkthroughThe Vercel configuration file ( 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/web/vercel.json (1)
32-32: Optional: drop the emptyfunctionsobject.Since there are no per-function overrides left, the empty
"functions": {}key can be removed entirely — Vercel will simply use defaults. Keeping an empty stanza is harmless but adds noise.♻️ Proposed cleanup
- ], - "functions": {} + ] }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/vercel.json` at line 32, Remove the empty "functions": {} stanza from the JSON so Vercel will use defaults; locate the apps/web vercel.json entry containing the literal key "functions" with an empty object and delete that key-value pair (no other changes required).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apps/web/vercel.json`:
- Line 32: Remove the empty "functions": {} stanza from the JSON so Vercel will
use defaults; locate the apps/web vercel.json entry containing the literal key
"functions" with an empty object and delete that key-value pair (no other
changes required).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cc44a591-bf58-4271-a026-6e71328a1e6f
📒 Files selected for processing (1)
apps/web/vercel.json
Summary
apps/web/vercel.jsonVerification
node -e 'JSON.parse(require("fs").readFileSync("apps/web/vercel.json","utf8")); console.log("vercel.json valid")'\n- verified these routes are absent:\n -apps/web/app/api/cron/workflows/scheduleEmailReminders/route.ts\n -apps/web/app/api/cron/workflows/scheduleSMSReminders/route.ts\n -apps/web/app/api/cron/workflows/scheduleWhatsappReminders/route.ts\n -apps/web/pages/api/trpc/workflows/[trpc].ts\n-yarn type-check:ci --force