Skip to content

fix(signup): prevent right panel content overflow on lg screens#29268

Closed
erete22 wants to merge 1 commit into
calcom:mainfrom
erete22:fix/signup-right-panel-overflow
Closed

fix(signup): prevent right panel content overflow on lg screens#29268
erete22 wants to merge 1 commit into
calcom:mainfrom
erete22:fix/signup-right-panel-overflow

Conversation

@erete22
Copy link
Copy Markdown

@erete22 erete22 commented May 4, 2026

Problem

On the signup page (/signup), at lg breakpoints the right panel (product badges, rating logos, features grid) was visually clipped on the right edge.

Root cause: The three inner grid divs each had mr-12 (48 px right margin) while their parent container only had pl-4 lg:pl-12 with no right padding. Content overflowed and was cut off by the ancestor overflow-hidden container.

Fix

Location Before After
Panel container pl-4 lg:pl-12 pl-4 pr-4 lg:pl-12 lg:pr-12
Badge grid row 1 -mt-4 mr-12 mb-6 … pr-4 -mt-4 mb-6 …
Badge grid row 2 mr-12 mb-6 … pr-4 mb-6 …
Features grid mt-8 mr-12 hidden … mt-8 hidden …

Adding pr-4 lg:pr-12 to the panel gives symmetric spacing matching pl-4 lg:pl-12, removing the need for child margin overflows.

Fixes #29266

The right panel on the signup page (/signup) clipped the product-card
badge grids and feature list on large screens. Root cause: the three
inner grid divs each had `mr-12` (48 px right margin) while the parent
container had no right padding, so content overflowed and was cut off
by the ancestor `overflow-hidden` container.

Fix:
- Add `pr-4 lg:pr-12` to the panel container to match `pl-4 lg:pl-12`,
  giving symmetric horizontal spacing on both sides.
- Remove `mr-12` and `pr-4` from the two badge-card grid divs
  (spacing is now owned by the parent container).
- Remove `mr-12` from the features grid div.

Fixes calcom#29266
@github-actions github-actions Bot added the 🐛 bug Something isn't working label May 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Welcome to Cal.diy, @erete22! Thanks for opening this pull request.

A few things to keep in mind:

  • This is Cal.diy, not Cal.com. Cal.diy is a community-driven, fully open-source fork of Cal.com licensed under MIT. Your changes here will be part of Cal.diy — they will not be deployed to the Cal.com production app.
  • Please review our Contributing Guidelines if you haven't already.
  • Make sure your PR title follows the Conventional Commits format.

A maintainer will review your PR soon. Thanks for contributing!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2f8c2dd1-5121-476e-8689-4f49785d7cd6

📥 Commits

Reviewing files that changed from the base of the PR and between 46eb533 and 1a8ae31.

📒 Files selected for processing (1)
  • apps/web/modules/signup-view.tsx

📝 Walkthrough

Walkthrough

The signup view module (apps/web/modules/signup-view.tsx) underwent a comprehensive code reformatting that restructured imports, constants, JSX layouts, and class name strings. All functional behavior—including form validation schema, username availability verification, Cloudflare Turnstile integration, Stripe checkout redirection, account review status handling, GTM and PostHog event tracking, and authentication callback URL construction—remains unchanged. No modifications were made to exported component signatures or type definitions.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: fixing right panel content overflow on lg screens in the signup page.
Description check ✅ Passed The description clearly explains the problem, root cause, and solution with a detailed before/after table showing all CSS changes made.
Linked Issues check ✅ Passed The PR addresses the signup page portion of issue #29266 by fixing the right panel overflow via symmetric padding adjustments and removing conflicting child margins.
Out of Scope Changes check ✅ Passed All changes are focused on fixing the signup page overflow issue; no unrelated modifications to other components or files are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Member

@romitg2 romitg2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please attach before and after video.

@romitg2 romitg2 marked this pull request as draft May 11, 2026 05:28
@github-actions
Copy link
Copy Markdown
Contributor

This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active.

@github-actions github-actions Bot added the Stale label May 19, 2026
@romitg2 romitg2 closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working size/XXL Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] : Homepage calendar is cut off on the right + ratings section misaligned + sign up page text from the right is also shown cutted

3 participants