fix(signup): prevent right panel content overflow on lg screens#29268
fix(signup): prevent right panel content overflow on lg screens#29268erete22 wants to merge 1 commit into
Conversation
The right panel on the signup page (/signup) clipped the product-card badge grids and feature list on large screens. Root cause: the three inner grid divs each had `mr-12` (48 px right margin) while the parent container had no right padding, so content overflowed and was cut off by the ancestor `overflow-hidden` container. Fix: - Add `pr-4 lg:pr-12` to the panel container to match `pl-4 lg:pl-12`, giving symmetric horizontal spacing on both sides. - Remove `mr-12` and `pr-4` from the two badge-card grid divs (spacing is now owned by the parent container). - Remove `mr-12` from the features grid div. Fixes calcom#29266
|
Welcome to Cal.diy, @erete22! Thanks for opening this pull request. A few things to keep in mind:
A maintainer will review your PR soon. Thanks for contributing! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe signup view module ( 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
|
|
romitg2
left a comment
There was a problem hiding this comment.
please attach before and after video.
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
Problem
On the signup page (
/signup), atlgbreakpoints the right panel (product badges, rating logos, features grid) was visually clipped on the right edge.Root cause: The three inner grid divs each had
mr-12(48 px right margin) while their parent container only hadpl-4 lg:pl-12with no right padding. Content overflowed and was cut off by the ancestoroverflow-hiddencontainer.Fix
pl-4 lg:pl-12pl-4 pr-4 lg:pl-12 lg:pr-12-mt-4 mr-12 mb-6 … pr-4-mt-4 mb-6 …mr-12 mb-6 … pr-4mb-6 …mt-8 mr-12 hidden …mt-8 hidden …Adding
pr-4 lg:pr-12to the panel gives symmetric spacing matchingpl-4 lg:pl-12, removing the need for child margin overflows.Fixes #29266