Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "element-internals-polyfill",
"version": "3.0.1",
"version": "3.0.2",
"description": "A polyfill for the element internals specification",
"main": "dist/index.js",
"module": "dist/index.js",
Expand Down
12 changes: 6 additions & 6 deletions src/element-internals.ts
Original file line number Diff line number Diff line change
Expand Up @@ -243,14 +243,14 @@ export class ElementInternals implements globalThis.ElementInternals {
const validity = validityMap.get(this);
const validityChangesObj: Partial<ValidityState> = {};
for (const key in validityChanges) {
if (key === "valid") {
continue;
}
validityChangesObj[key] = validityChanges[key];
}
if (Object.keys(validityChangesObj).length === 0) {
setValid(validity);
}
const check = { ...validity, ...validityChangesObj };
delete check.valid;
const { valid } = reconcileValidity(validity, check, this.form);

setValid(validity);
const { valid } = reconcileValidity(validity, validityChangesObj, this.form);

if (!valid && !validationMessage) {
throw new DOMException(
Expand Down
17 changes: 17 additions & 0 deletions test/ElementInternals.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,23 @@ describe('The ElementInternals polyfill', () => {
expect(internals.validity.valid).to.be.true;
});

it('will clear omitted validity flags on subsequent setValidity calls', () => {
internals.setValidity({
valueMissing: true
}, 'This field is required');

expect(internals.validity.valueMissing).to.be.true;
expect(internals.validity.valid).to.be.false;

internals.setValidity({
customError: false
});

expect(internals.validity.valueMissing).to.be.false;
expect(internals.validity.customError).to.be.false;
expect(internals.validity.valid).to.be.true;
});

it('will throw if setValidity is called with a flag and no validation message', () => {
expect(() => {
internals.setValidity({
Expand Down