Skip to content

Commit 009a51f

Browse files
committed
Merge branch 'main' into dsilva_fixWarnings
2 parents 8b83961 + 5ec41d0 commit 009a51f

25 files changed

Lines changed: 401 additions & 120 deletions

File tree

src/ROUTES.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -728,11 +728,11 @@ const ROUTES = {
728728
},
729729
MONEY_REQUEST_EDIT_REPORT: {
730730
route: ':action/:iouType/report/:reportID/edit',
731-
getRoute: (action: IOUAction, iouType: IOUType, reportID?: string, backTo = '') => {
731+
getRoute: (action: IOUAction, iouType: IOUType, reportID?: string, shouldTurnOffSelectionMode?: boolean, backTo = '') => {
732732
if (!reportID) {
733733
Log.warn('Invalid reportID while building route MONEY_REQUEST_EDIT_REPORT');
734734
}
735-
return getUrlWithBackToParam(`${action as string}/${iouType as string}/report/${reportID}/edit`, backTo);
735+
return getUrlWithBackToParam(`${action as string}/${iouType as string}/report/${reportID}/edit${shouldTurnOffSelectionMode ? `?shouldTurnOffSelectionMode=true` : ``}`, backTo);
736736
},
737737
},
738738
SETTINGS_TAGS_ROOT: {

src/components/SubStepForms/CountryFullStep/subSteps/Confirmation.tsx

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import React, {useCallback, useEffect, useState} from 'react';
2+
import {View} from 'react-native';
23
import FormProvider from '@components/Form/FormProvider';
34
import InputWrapper from '@components/Form/InputWrapper';
45
import type {FormInputErrors, FormOnyxValues} from '@components/Form/types';
@@ -90,16 +91,18 @@ function Confirmation({onNext, policyID}: ConfirmationStepProps) {
9091
title={currency}
9192
interactive={false}
9293
/>
93-
<Text style={[styles.ph5, styles.mb3, styles.mutedTextLabel]}>
94-
{`${translate('countryStep.yourBusiness')} ${translate('countryStep.youCanChange')}`}{' '}
95-
<TextLink
96-
style={[styles.label]}
97-
onPress={handleSettingsPress}
98-
>
99-
{translate('common.settings').toLowerCase()}
100-
</TextLink>
101-
.
102-
</Text>
94+
<View style={styles.ph5}>
95+
<Text style={[styles.mb3, styles.mutedTextLabel]}>
96+
{`${translate('countryStep.yourBusiness')} ${translate('countryStep.youCanChange')}`}{' '}
97+
<TextLink
98+
style={[styles.label]}
99+
onPress={handleSettingsPress}
100+
>
101+
{translate('common.settings').toLowerCase()}
102+
</TextLink>
103+
.
104+
</Text>
105+
</View>
103106
<InputWrapper
104107
InputComponent={PushRowWithModal}
105108
optionsList={shouldAllowChange ? CONST.ALL_EUROPEAN_UNION_COUNTRIES : CONST.ALL_COUNTRIES}

src/components/TransactionItemRow/DataCells/ChatBubbleCell.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import useResponsiveLayout from '@hooks/useResponsiveLayout';
99
import useStyleUtils from '@hooks/useStyleUtils';
1010
import useTheme from '@hooks/useTheme';
1111
import useThemeStyles from '@hooks/useThemeStyles';
12+
import getNonEmptyStringOnyxID from '@libs/getNonEmptyStringOnyxID';
1213
import {getIOUActionForTransactionID} from '@libs/ReportActionsUtils';
1314
import {isChatThread} from '@libs/ReportUtils';
1415
import variables from '@styles/variables';
@@ -23,7 +24,9 @@ function ChatBubbleCell({transaction, containerStyles, isInSingleTransactionRepo
2324
const theme = useTheme();
2425
const styles = useThemeStyles();
2526
const {shouldUseNarrowLayout} = useResponsiveLayout();
26-
const [iouReportAction] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${transaction.reportID}`, {
27+
const nonEmptyStringTransactionReportID = getNonEmptyStringOnyxID(transaction.reportID);
28+
29+
const [iouReportAction] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${nonEmptyStringTransactionReportID}`, {
2730
selector: (reportActions) => getIOUActionForTransactionID(Object.values(reportActions ?? {}), transaction.transactionID),
2831
canBeMissing: true,
2932
});
@@ -32,7 +35,7 @@ function ChatBubbleCell({transaction, containerStyles, isInSingleTransactionRepo
3235
canBeMissing: true,
3336
});
3437

35-
const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${transaction.reportID}`, {
38+
const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${nonEmptyStringTransactionReportID}`, {
3639
canBeMissing: false,
3740
});
3841

src/hooks/useSelectedTransactionsActions.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,8 @@ function useSelectedTransactionsActions({
204204
icon: Expensicons.DocumentMerge,
205205
value: MOVE,
206206
onSelected: () => {
207-
const route = ROUTES.MONEY_REQUEST_EDIT_REPORT.getRoute(CONST.IOU.ACTION.EDIT, iouType, report?.reportID);
207+
const shouldTurnOffSelectionMode = allTransactionsLength - selectedTransactionIDs.length <= 1;
208+
const route = ROUTES.MONEY_REQUEST_EDIT_REPORT.getRoute(CONST.IOU.ACTION.EDIT, iouType, report?.reportID, shouldTurnOffSelectionMode);
208209
Navigation.navigate(route);
209210
},
210211
});
@@ -235,13 +236,14 @@ function useSelectedTransactionsActions({
235236
report,
236237
selectedTransactions,
237238
translate,
239+
isReportArchived,
238240
reportActions,
239241
clearSelectedTransactions,
240242
onExportFailed,
243+
allTransactionsLength,
241244
iouType,
242245
session?.accountID,
243246
showDeleteModal,
244-
isReportArchived,
245247
]);
246248

247249
return {

src/languages/de.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1077,6 +1077,8 @@ const translations = {
10771077
scanMultipleReceiptsDescription: 'Machen Sie Fotos von all Ihren Belegen auf einmal, dann bestätigen Sie die Details selbst oder lassen Sie SmartScan dies übernehmen.',
10781078
receiptScanInProgress: 'Belegscan läuft',
10791079
receiptScanInProgressDescription: 'Belegscan läuft. Später erneut prüfen oder die Details jetzt eingeben.',
1080+
removeFromReport: 'Ausgabe aus Bericht entfernen',
1081+
moveToPersonalSpace: 'Ausgaben in persönlichen Bereich verschieben',
10801082
duplicateTransaction: ({isSubmitted}: DuplicateTransactionParams) =>
10811083
!isSubmitted
10821084
? 'Mögliche doppelte Ausgaben erkannt. Überprüfen Sie die Duplikate, um die Einreichung zu ermöglichen.'
@@ -1837,7 +1839,7 @@ const translations = {
18371839
expensifyWallet: 'Expensify Wallet (Beta)',
18381840
sendAndReceiveMoney: 'Senden und Empfangen von Geld mit Freunden. Nur US-Bankkonten.',
18391841
enableWallet: 'Wallet aktivieren',
1840-
addBankAccountToSendAndReceive: 'Erhalten Sie eine Rückerstattung für Ausgaben, die Sie an einen Arbeitsbereich einreichen.',
1842+
addBankAccountToSendAndReceive: 'Fügen Sie ein Bankkonto hinzu, um Zahlungen zu tätigen oder zu empfangen.',
18411843
assignedCards: 'Zugewiesene Karten',
18421844
assignedCardsDescription: 'Dies sind Karten, die von einem Workspace-Admin zugewiesen wurden, um die Ausgaben des Unternehmens zu verwalten.',
18431845
expensifyCard: 'Expensify Card',
@@ -1848,6 +1850,8 @@ const translations = {
18481850
chooseYourBankAccount: 'Wählen Sie Ihr Bankkonto aus',
18491851
chooseAccountBody: 'Stellen Sie sicher, dass Sie das richtige auswählen.',
18501852
confirmYourBankAccount: 'Bestätigen Sie Ihr Bankkonto',
1853+
personalBankAccounts: 'Persönliche Bankkonten',
1854+
businessBankAccounts: 'Geschäftsbankkonten',
18511855
},
18521856
cardPage: {
18531857
expensifyCard: 'Expensify Card',

src/languages/en.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1063,6 +1063,8 @@ const translations = {
10631063
scanMultipleReceiptsDescription: "Snap photos of all your receipts at once, then confirm details yourself or we'll do it for you.",
10641064
receiptScanInProgress: 'Receipt scan in progress',
10651065
receiptScanInProgressDescription: 'Receipt scan in progress. Check back later or enter the details now.',
1066+
removeFromReport: 'Remove from report',
1067+
moveToPersonalSpace: 'Move expenses to your personal space',
10661068
duplicateTransaction: ({isSubmitted}: DuplicateTransactionParams) =>
10671069
!isSubmitted
10681070
? 'Potential duplicate expenses identified. Review duplicates to enable submission.'
@@ -1815,7 +1817,7 @@ const translations = {
18151817
expensifyWallet: 'Expensify Wallet (Beta)',
18161818
sendAndReceiveMoney: 'Send and receive money with friends. US bank accounts only.',
18171819
enableWallet: 'Enable wallet',
1818-
addBankAccountToSendAndReceive: 'Get paid back for expenses you submit to a workspace.',
1820+
addBankAccountToSendAndReceive: 'Add a bank account to make or receive payments.',
18191821
assignedCards: 'Assigned cards',
18201822
assignedCardsDescription: 'These are cards assigned by a workspace admin to manage company spend.',
18211823
expensifyCard: 'Expensify Card',
@@ -1826,6 +1828,8 @@ const translations = {
18261828
chooseYourBankAccount: 'Choose your bank account',
18271829
chooseAccountBody: 'Make sure that you select the right one.',
18281830
confirmYourBankAccount: 'Confirm your bank account',
1831+
personalBankAccounts: 'Personal bank accounts',
1832+
businessBankAccounts: 'Business bank accounts',
18291833
},
18301834
cardPage: {
18311835
expensifyCard: 'Expensify Card',

src/languages/es.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1062,6 +1062,8 @@ const translations = {
10621062
scanMultipleReceiptsDescription: 'Haz fotos de todos tus recibos a la vez y confirma los detalles tú mismo o nosotros lo haremos por ti.',
10631063
receiptScanInProgress: 'Escaneado de recibo en proceso',
10641064
receiptScanInProgressDescription: 'Escaneado de recibo en proceso. Vuelve a comprobarlo más tarde o introduce los detalles ahora.',
1065+
removeFromReport: 'Eliminar del informe',
1066+
moveToPersonalSpace: 'Mover gastos a tu espacio personal',
10651067
duplicateTransaction: ({isSubmitted}: DuplicateTransactionParams) =>
10661068
!isSubmitted
10671069
? 'Se han identificado posibles gastos duplicados. Revisa los duplicados para habilitar el envío.'
@@ -1813,7 +1815,7 @@ const translations = {
18131815
expensifyWallet: 'Billetera Expensify (Beta)',
18141816
sendAndReceiveMoney: 'Envía y recibe dinero desde tu Billetera Expensify. Solo cuentas bancarias de EE. UU.',
18151817
enableWallet: 'Habilitar billetera',
1816-
addBankAccountToSendAndReceive: 'Recibe el reembolso de los gastos que envíes a un espacio de trabajo.',
1818+
addBankAccountToSendAndReceive: 'Añade una cuenta bancaria para hacer o recibir pagos.',
18171819
assignedCards: 'Tarjetas asignadas',
18181820
assignedCardsDescription: 'Son tarjetas asignadas por un administrador del espacio de trabajo para gestionar los gastos de la empresa.',
18191821
expensifyCard: 'Tarjeta Expensify',
@@ -1824,6 +1826,8 @@ const translations = {
18241826
chooseYourBankAccount: 'Elige tu cuenta bancaria',
18251827
chooseAccountBody: 'Asegúrese de elegir el adecuado.',
18261828
confirmYourBankAccount: 'Confirma tu cuenta bancaria',
1829+
personalBankAccounts: 'Cuentas bancarias personales',
1830+
businessBankAccounts: 'Cuentas bancarias empresariales',
18271831
},
18281832
cardPage: {
18291833
expensifyCard: 'Tarjeta Expensify',

src/languages/fr.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1079,6 +1079,8 @@ const translations = {
10791079
scanMultipleReceiptsDescription: "Prenez des photos de tous vos reçus en une seule fois, puis confirmez les détails vous-même ou laissez SmartScan s'en charger.",
10801080
receiptScanInProgress: 'Numérisation du reçu en cours',
10811081
receiptScanInProgressDescription: 'Numérisation du reçu en cours. Revenez plus tard ou saisissez les détails maintenant.',
1082+
removeFromReport: 'Supprimer du rapport',
1083+
moveToPersonalSpace: 'Déplacer les dépenses vers votre espace personnel',
10821084
duplicateTransaction: ({isSubmitted}: DuplicateTransactionParams) =>
10831085
!isSubmitted
10841086
? 'Dépenses potentiellement en double identifiées. Vérifiez les doublons pour permettre la soumission.'
@@ -1839,7 +1841,7 @@ const translations = {
18391841
expensifyWallet: 'Expensify Wallet (Bêta)',
18401842
sendAndReceiveMoney: "Envoyez et recevez de l'argent avec des amis. Comptes bancaires américains uniquement.",
18411843
enableWallet: 'Activer le portefeuille',
1842-
addBankAccountToSendAndReceive: 'Soyez remboursé pour les dépenses que vous soumettez à un espace de travail.',
1844+
addBankAccountToSendAndReceive: 'Ajoutez un compte bancaire pour effectuer ou recevoir des paiements.',
18431845
assignedCards: 'Cartes assignées',
18441846
assignedCardsDescription: "Ce sont des cartes attribuées par un administrateur d'espace de travail pour gérer les dépenses de l'entreprise.",
18451847
expensifyCard: 'Expensify Card',
@@ -1850,6 +1852,8 @@ const translations = {
18501852
chooseYourBankAccount: 'Choisissez votre compte bancaire',
18511853
chooseAccountBody: 'Assurez-vous de sélectionner le bon.',
18521854
confirmYourBankAccount: 'Confirmez votre compte bancaire',
1855+
personalBankAccounts: 'Comptes bancaires personnels',
1856+
businessBankAccounts: 'Comptes bancaires professionnels',
18531857
},
18541858
cardPage: {
18551859
expensifyCard: 'Expensify Card',

src/languages/it.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1074,6 +1074,8 @@ const translations = {
10741074
scanMultipleReceiptsDescription: 'Scatta foto di tutte le tue ricevute in una volta, poi conferma i dettagli tu stesso o lascia che SmartScan se ne occupi.',
10751075
receiptScanInProgress: 'Scansione della ricevuta in corso',
10761076
receiptScanInProgressDescription: 'Scansione della ricevuta in corso. Controlla più tardi o inserisci i dettagli ora.',
1077+
removeFromReport: 'Rimuovi dal rapporto',
1078+
moveToPersonalSpace: 'Sposta spese nello spazio personale',
10771079
duplicateTransaction: ({isSubmitted}: DuplicateTransactionParams) =>
10781080
!isSubmitted
10791081
? "Spese potenzialmente duplicate identificate. Rivedi i duplicati per consentire l'invio."
@@ -1831,7 +1833,7 @@ const translations = {
18311833
expensifyWallet: 'Expensify Wallet (Beta)',
18321834
sendAndReceiveMoney: 'Invia e ricevi denaro con gli amici. Solo conti bancari statunitensi.',
18331835
enableWallet: 'Abilita portafoglio',
1834-
addBankAccountToSendAndReceive: "Ricevi il rimborso per le spese che invii a un'area di lavoro.",
1836+
addBankAccountToSendAndReceive: 'Aggiungi un conto bancario per effettuare o ricevere pagamenti.',
18351837
assignedCards: 'Carte assegnate',
18361838
assignedCardsDescription: 'Queste sono carte assegnate da un amministratore del workspace per gestire le spese aziendali.',
18371839
expensifyCard: 'Expensify Card',
@@ -1842,6 +1844,8 @@ const translations = {
18421844
chooseYourBankAccount: 'Scegli il tuo conto bancario',
18431845
chooseAccountBody: 'Assicurati di selezionare quello giusto.',
18441846
confirmYourBankAccount: 'Conferma il tuo conto bancario',
1847+
personalBankAccounts: 'Conti bancari personali',
1848+
businessBankAccounts: 'Conti bancari aziendali',
18451849
},
18461850
cardPage: {
18471851
expensifyCard: 'Expensify Card',

src/languages/ja.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1076,6 +1076,8 @@ const translations = {
10761076
scanMultipleReceiptsDescription: 'すべての領収書を一度に撮影し、自分で詳細を確認するか、SmartScanに任せましょう。',
10771077
receiptScanInProgress: '領収書のスキャン中',
10781078
receiptScanInProgressDescription: '領収書のスキャン中です。後で確認するか、今すぐ詳細を入力してください。',
1079+
removeFromReport: '領収書を削除',
1080+
moveToPersonalSpace: '領収書を個人スペースに移動',
10791081
duplicateTransaction: ({isSubmitted}: DuplicateTransactionParams) =>
10801082
!isSubmitted
10811083
? '重複の可能性がある経費が特定されました。提出を有効にするために重複を確認してください。'
@@ -1828,7 +1830,7 @@ const translations = {
18281830
expensifyWallet: 'Expensify Wallet(ベータ版)',
18291831
sendAndReceiveMoney: '友達とお金を送受信する。米国の銀行口座のみ。',
18301832
enableWallet: 'ウォレットを有効にする',
1831-
addBankAccountToSendAndReceive: 'ワークスペースに提出した経費の払い戻しを受ける。',
1833+
addBankAccountToSendAndReceive: '支払いや受け取りを行うために銀行口座を追加してください。',
18321834
assignedCards: '割り当てられたカード',
18331835
assignedCardsDescription: 'これらは、会社の支出を管理するためにワークスペース管理者によって割り当てられたカードです。',
18341836
expensifyCard: 'Expensify Card',
@@ -1839,6 +1841,8 @@ const translations = {
18391841
chooseYourBankAccount: '銀行口座を選択してください',
18401842
chooseAccountBody: '正しいものを選択してください。',
18411843
confirmYourBankAccount: '銀行口座を確認してください',
1844+
personalBankAccounts: '個人銀行口座',
1845+
businessBankAccounts: 'ビジネス銀行口座',
18421846
},
18431847
cardPage: {
18441848
expensifyCard: 'Expensify Card',

0 commit comments

Comments
 (0)