Skip to content

Commit 015d296

Browse files
author
Nabi Ebrahimi
committed
Merge branch 'main' into fix/reload-resets-workspace-bg
2 parents 760a288 + 665f42d commit 015d296

194 files changed

Lines changed: 4435 additions & 3237 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.eslintrc.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,7 @@ module.exports = {
230230
'rulesdir/no-multiple-onyx-in-file': 'off',
231231
'rulesdir/prefer-underscore-method': 'off',
232232
'rulesdir/prefer-import-module-contents': 'off',
233+
'rulesdir/no-beta-handler': 'error',
233234

234235
// React and React Native specific rules
235236
'react-native-a11y/has-accessibility-hint': ['off'],

.github/workflows/publishReactNativeAndroidArtifacts.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ on:
1818
- package.json
1919
- patches/react-native+*.patch
2020
- patches/@react-native+*.patch
21+
- patches/react-native/react-native+*.patch
22+
- patches/react-native/@react-native+*.patch
2123
- Mobile-Expensify
2224

2325
jobs:

Mobile-Expensify

android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ android {
114114
minSdkVersion rootProject.ext.minSdkVersion
115115
targetSdkVersion rootProject.ext.targetSdkVersion
116116
multiDexEnabled rootProject.ext.multiDexEnabled
117-
versionCode 1009017601
118-
versionName "9.1.76-1"
117+
versionCode 1009017701
118+
versionName "9.1.77-1"
119119
// Supported language variants must be declared here to avoid from being removed during the compilation.
120120
// This also helps us to not include unnecessary language variants in the APK.
121121
resConfigs "en", "es"

contributingGuides/NAVIGATION.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,7 @@ In Expensify, we use an extended implementation of this function because:
503503

504504
Here are examples how the state is generated based on route:
505505

506-
- `settings/workspaces/1/overview`
506+
- `workspaces/1/overview`
507507

508508
```json
509509
{
@@ -536,7 +536,7 @@ Here are examples how the state is generated based on route:
536536
"params": {
537537
"policyID": "1"
538538
},
539-
"path": "/settings/workspaces/1/overview",
539+
"path": "workspaces/1/overview",
540540
"key": "Workspace_Overview-key"
541541
}
542542
]

contributingGuides/NAVIGATION_TESTS.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@
3333

3434
1. Open any workspace settings (Settings → Workspaces → Select any workspace)
3535
2. Click the Settings button on the bottom tab.
36-
3. Verify that the Workspace list is displayed (`/settings/workspaces`)
36+
3. Verify that the Workspace list is displayed (`/workspaces`)
3737
4. Select any workspace again.
3838
5. Reload the page.
3939
6. Click the Settings button on the bottom tab.
40-
7. Verify that the Workspace list is displayed (`/settings/workspaces`)
40+
7. Verify that the Workspace list is displayed (`/workspaces/`)
4141

4242

4343
#### The last visited screen in the settings tab is saved when switching between tabs
@@ -52,7 +52,7 @@
5252

5353
#### Going up to the workspace list page after refreshing on the workspace settings and pressing the up button
5454

55-
1. Open the workspace settings from the deep link (use a link in format: `/settings/workspaces/:policyID:/profile`)
55+
1. Open the workspace settings from the deep link (use a link in format: `/workspaces/:policyID:/profile`)
5656
2. Click the app’s back button.
5757
3. Verify if the workspace list is displayed.
5858

@@ -241,4 +241,4 @@ Linked issue: https://github.com/Expensify/App/issues/50177
241241
11. Go back.
242242
12. Verify you are navigated back to the employee size step.
243243
13. Go back.
244-
14. Verify you are navigated back to the Purpose step.
244+
14. Verify you are navigated back to the Purpose step.

contributingGuides/STYLE.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -535,13 +535,13 @@ We need to change the `getRoute()` `policyID` argument type to allow `undefined`
535535
536536
```diff
537537
WORKSPACE_PROFILE_ADDRESS: {
538-
route: 'settings/workspaces/:policyID/profile/address',
539-
- getRoute: (policyID: string, backTo?: string) => getUrlWithBackToParam(`settings/workspaces/${policyID}/profile/address` as const, backTo),
538+
route: 'workspaces/:policyID/profile/address',
539+
- getRoute: (policyID: string, backTo?: string) => getUrlWithBackToParam(`workspaces/${policyID}/profile/address` as const, backTo),
540540
+ getRoute: (policyID: string | undefined, backTo?: string) => {
541541
+ if (!policyID) {
542542
+ Log.warn("Invalid policyID is used to build the WORKSPACE_PROFILE_ADDRESS route")
543543
+ }
544-
+ return getUrlWithBackToParam(`settings/workspaces/${policyID}/profile/address` as const, backTo);
544+
+ return getUrlWithBackToParam(`workspaces/${policyID}/profile/address` as const, backTo);
545545
+ },
546546
},
547547
```

docs/articles/expensify-classic/travel/Approve-travel-expenses.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@ title: Approve travel expenses
33
description: Determine how travel expenses are approved
44
---
55

6-
Travel expenses follow the same approval workflow as other expenses. Admins can configure travel expenses to be approved as soft approval, hard approval or passive approval. The approval method for in-policy and out-of-policy bookings can be managed under the **Policies** section in the **Program** menu for Expensify Travel.
6+
Travel expenses follow the same approval workflow as other expenses. Admins can configure travel expenses to be approved as soft approval, hard approval or passive approval. The approval method for in-policy and out-of-policy bookings can be managed under the **Policies** section in the **Program** menu for Expensify Travel.
7+
8+
Trip itineraries are maintained with complete booking information, ensuring accurate trip details are always available regardless of how individual expenses are handled.
79

810
- **Soft Approval**: Bookings are automatically approved as long as a manager does not decline them within 24 hours. However, this also means that if a manager does not decline the expenses, the arrangements will be booked even if they are out of policy. If a booking is declined, it is refunded based on the voiding/refund terms of the service provider.
911
- **Hard Approval**: Bookings are automatically canceled/voided and refunded if a manager does not approve them within 24 hours.

docs/articles/expensify-classic/travel/Book-With-Expensify-Travel.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ To book travel from the Expensify web app,
3434

3535
The traveler is emailed an itinerary of the booking. Additionally,
3636
- Their travel details are added to a Trip chat room under their primary workspace.
37-
- An expense report for the trip is created.
37+
- Travel expenses are automatically added to expense reports following your workspace's scheduled submit rules.
3838
- If booked with an Expensify Card, the trip is automatically reconciled.
3939

4040
{% include info.html %}

docs/articles/expensify-classic/travel/Edit-or-cancel-travel-arrangements.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ title: Edit or cancel travel arrangements
33
description: Modify travel arrangements booked with Expensify Travel
44
---
55

6+
Your trip itinerary is maintained with the latest booking information and can be accessed any time through your trip room.
7+
68
To edit or cancel a travel arrangement,
79
1. Click Travel in the left menu.
810
2. Click Book or Manage Travel.

0 commit comments

Comments
 (0)