fix: report briefly shown with 0,00 as amount and no receipt thumbnail when deleted

Author: mkzie2

src/components/Search/index.tsx

@@ -518,7 +518,8 @@ function Search({queryJSON, currentSearchResults, lastNonEmptySearchResults, onS
         );
     }
 
-    if (shouldShowEmptyState(isDataLoaded, data.length, searchResults.search.type)) {
+    const visibleDataLength = data.filter((item) => item.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || isOffline).length;
+    if (shouldShowEmptyState(isDataLoaded, visibleDataLength, searchResults.search.type)) {
         return (
             <View style={[shouldUseNarrowLayout ? styles.searchListContentContainerStyles : styles.mt3, styles.flex1]}>
                 <EmptySearchView

src/libs/SearchUIUtils.ts

@@ -772,6 +772,7 @@ function getReportSections(data: OnyxTypes.SearchResults['data'], metadata: Onyx
                 from: data.personalDetailsList?.[reportItem.accountID ?? CONST.DEFAULT_NUMBER_ID],
                 to: reportItem.managerID ? data.personalDetailsList?.[reportItem.managerID] : emptyPersonalDetails,
                 transactions,
+                pendingAction: reportItem?.pendingAction ?? reportItem?.pendingFields?.preview,
             };
 
             if (isIOUReport) {

src/libs/actions/IOU.ts

@@ -7435,6 +7435,10 @@ function prepareToCleanUpMoneyRequest(transactionID: string, reportAction: OnyxT
         );
     }
 
+    if (shouldDeleteIOUReport && updatedIOUReport) {
+        updatedIOUReport.pendingAction = CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;
+    }
+
     if (updatedIOUReport) {
         const lastVisibleAction = getLastVisibleAction(iouReport?.reportID, canUserPerformWriteAction, updatedReportAction);
         const iouReportLastMessageText = getLastVisibleMessage(iouReport?.reportID, canUserPerformWriteAction, updatedReportAction).lastMessageText;

src/types/onyx/SearchResults.ts

@@ -179,6 +179,15 @@ type SearchReport = {
 
     /** The policy name to use for an archived report */
     oldPolicyName?: string;
+
+    /** Pending fields for the report */
+    pendingFields?: {
+        /** Pending action for the preview */
+        preview?: OnyxCommon.PendingAction;
+    };
+
+    /** Pending action for the report */
+    pendingAction?: OnyxCommon.PendingAction;
 };
 
 /** Model of report action search result */