Merge pull request Expensify#64377 from FitseTLT/fix-showing-export-for-invoice-reports

Fix - Invoice-Inconsistency in exporting unpaid invoice depending on where export button is accessed

Author: puneetlath

src/libs/ReportPrimaryActionUtils.ts

@@ -191,7 +191,9 @@ function isExportAction(report: Report, policy?: Policy, reportActions?: ReportA
     }
 
     const connectedIntegration = getValidConnectedIntegration(policy);
-    if (!connectedIntegration) {
+    const isInvoiceReport = isInvoiceReportUtils(report);
+
+    if (!connectedIntegration || isInvoiceReport) {
         return false;
     }
 

src/libs/ReportSecondaryActionUtils.ts

@@ -271,10 +271,10 @@ function isExportAction(report: Report, policy?: Policy, reportActions?: ReportA
     }
 
     const isInvoiceReport = isInvoiceReportUtils(report);
-    const isReportSender = isCurrentUserSubmitter(report.reportID);
 
-    if (isInvoiceReport && isReportSender) {
-        return true;
+    // We don't allow export to accounting for invoice reports in OD so we want to align with that here.
+    if (isInvoiceReport) {
+        return false;
     }
 
     const isExpenseReport = isExpenseReportUtils(report);

tests/unit/ReportPrimaryActionUtilsTest.ts

@@ -190,6 +190,34 @@ describe('getPrimaryAction', () => {
         );
     });
 
+    it('should not return EXPORT TO ACCOUNTING for invoice reports', async () => {
+        const report = {
+            reportID: REPORT_ID,
+            type: CONST.REPORT.TYPE.INVOICE,
+            ownerAccountID: CURRENT_USER_ACCOUNT_ID,
+            statusNum: CONST.REPORT.STATUS_NUM.CLOSED,
+        } as unknown as Report;
+        await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${REPORT_ID}`, report);
+        const policy = {
+            connections: {
+                intacct: {
+                    config: {
+                        export: {
+                            exporter: CURRENT_USER_EMAIL,
+                        },
+                    },
+                },
+            },
+        };
+        const transaction = {
+            reportID: `${REPORT_ID}`,
+        } as unknown as Transaction;
+
+        expect(getReportPrimaryAction({report, chatReport, reportTransactions: [transaction], violations: {}, policy: policy as Policy})).not.toBe(
+            CONST.REPORT.PRIMARY_ACTIONS.EXPORT_TO_ACCOUNTING,
+        );
+    });
+
     it('should not return EXPORT TO ACCOUNTING for reports marked manually as exported', async () => {
         const report = {
             reportID: REPORT_ID,

tests/unit/ReportSecondaryActionUtilsTest.ts

@@ -308,7 +308,7 @@ describe('getSecondaryAction', () => {
         expect(result.includes(CONST.REPORT.SECONDARY_ACTIONS.CANCEL_PAYMENT)).toBe(true);
     });
 
-    it('includes EXPORT option for invoice submitter', async () => {
+    it('does not include EXPORT option for invoice reports', async () => {
         const report = {
             reportID: REPORT_ID,
             type: CONST.REPORT.TYPE.INVOICE,
@@ -322,7 +322,7 @@ describe('getSecondaryAction', () => {
         await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${REPORT_ID}`, report);
 
         const result = getSecondaryReportActions({report, chatReport, reportTransactions: [], violations: {}, policy});
-        expect(result.includes(CONST.REPORT.SECONDARY_ACTIONS.EXPORT_TO_ACCOUNTING)).toBe(true);
+        expect(result.includes(CONST.REPORT.SECONDARY_ACTIONS.EXPORT_TO_ACCOUNTING)).toBe(false);
     });
 
     it('includes EXPORT option for expense report with payments enabled', () => {