Merge pull request Expensify#64651 from callstack-internal/fix-freezing-app-v1

Fix freezing app

Author: mountiny

src/libs/actions/OnyxDerived/configs/reportAttributes.ts

@@ -7,7 +7,6 @@ import ONYXKEYS from '@src/ONYXKEYS';
 import type {ReportAttributesDerivedValue} from '@src/types/onyx';
 
 let isFullyComputed = false;
-let recentlyUpdated: string[] = [];
 
 const prepareReportKeys = (keys: string[]) => {
     return [
@@ -48,7 +47,7 @@ export default createOnyxDerivedValueConfig({
         }
         // if any of those keys changed, reset the isFullyComputed flag to recompute all reports
         // we need to recompute all report attributes on locale change because the report names are locale dependent
-        if (hasKeyTriggeredCompute(ONYXKEYS.NVP_PREFERRED_LOCALE, sourceValues)) {
+        if (hasKeyTriggeredCompute(ONYXKEYS.NVP_PREFERRED_LOCALE, sourceValues) || hasKeyTriggeredCompute(ONYXKEYS.PERSONAL_DETAILS_LIST, sourceValues)) {
             isFullyComputed = false;
         }
 
@@ -89,16 +88,31 @@ export default createOnyxDerivedValueConfig({
             // if there are report-related updates, iterate over the updates
             if (updates.length > 0) {
                 dataToIterate = prepareReportKeys(updates);
-                recentlyUpdated = updates;
             } else if (!!transactionsUpdates || !!transactionViolationsUpdates) {
                 let transactionReportIDs: string[] = [];
                 if (transactionsUpdates) {
                     transactionReportIDs = Object.values(transactionsUpdates).map((transaction) => `${ONYXKEYS.COLLECTION.REPORT}${transaction?.reportID}`);
                 }
-                // if transactions are updated, they might not be directly related to the reports yet (e.g. transaction is optimistically created)
-                // so we use report keys that were updated before to recompute the reports
-                const recentReportKeys = prepareReportKeys([...recentlyUpdated, ...transactionReportIDs]);
-                dataToIterate = recentReportKeys;
+                // Also handle transaction violations updates by extracting transaction IDs and finding their reports
+                if (transactionViolationsUpdates) {
+                    const violationTransactionIDs = Object.keys(transactionViolationsUpdates).map((key) => key.replace(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS, ''));
+                    const violationReportIDs = violationTransactionIDs
+                        .map((transactionID) => transactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`]?.reportID)
+                        .filter(Boolean)
+                        .map((reportID) => `${ONYXKEYS.COLLECTION.REPORT}${reportID}`);
+
+                    // Also include chat reports for expense reports that have violations
+                    const chatReportIDs = violationReportIDs
+                        .map((reportKey) => reports?.[reportKey]?.chatReportID)
+                        .filter(Boolean)
+                        .map((chatReportID) => `${ONYXKEYS.COLLECTION.REPORT}${chatReportID}`);
+
+                    transactionReportIDs = [...transactionReportIDs, ...violationReportIDs, ...chatReportIDs];
+                }
+                dataToIterate = prepareReportKeys(transactionReportIDs);
+            } else {
+                // No updates to process, return current value to prevent unnecessary computation
+                return currentValue ?? {reports: {}, locale: null};
             }
         }
         const reportAttributes = dataToIterate.reduce<ReportAttributesDerivedValue['reports']>((acc, key) => {

tests/ui/LHNItemsPresence.tsx

@@ -232,6 +232,7 @@ describe('SidebarLinksData', () => {
                 ...createReport(false, undefined, undefined, undefined, TEST_POLICY_ID),
                 ownerAccountID: TEST_USER_ACCOUNT_ID,
                 type: CONST.REPORT.TYPE.EXPENSE,
+                chatReportID: report.reportID,
             };
             const transaction = LHNTestUtils.getFakeTransaction(expenseReport.reportID);
             const transactionViolation = createFakeTransactionViolation();