Skip to content

Commit 04a581c

Browse files
adhorodyskiclaude
andcommitted
Redistribute Performance & Technical items and remove section
Move testing-related items (markdown behavior, generic component testing, Storybook verification, component impact testing) to Testing & Verification section. Move code quality items (console error handling, useOnyx alerts) to Code Quality & Standards section. Remove Performance & Technical section to consolidate checklist from 7 to 6 sections while maintaining logical grouping. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 696f782 commit 04a581c

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

contributingGuides/REVIEWER_CHECKLIST.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@
2323
- [ ] MacOS: Chrome / Safari
2424
- [ ] MacOS: Desktop
2525
- [ ] For any bug fix or new feature in this PR, I verified that sufficient [unit tests](https://github.com/Expensify/App/blob/main/tests/README.md) are included to prevent regressions in this flow.
26+
- [ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
27+
- [ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like `Avatar` is modified, I verified that `Avatar` is working as expected in all cases)
28+
- [ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
29+
- [ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like `Avatar`, I verified the components using `Avatar` have been tested & I retested again)
2630

2731
### Code Quality & Standards
2832
- [ ] I verified proper code patterns were followed (see [Reviewing the code](https://github.com/Expensify/App/blob/main/contributingGuides/PR_REVIEW_GUIDELINES.md#reviewing-the-code))
@@ -39,6 +43,8 @@
3943
- [ ] If a new CSS style is added I verified that:
4044
- [ ] A similar style doesn't already exist
4145
- [ ] The style can't be created with an existing [StyleUtils](https://github.com/Expensify/App/blob/main/src/utils/index.ts) function (i.e. `StyleUtils.getBackgroundAndBorderStyle(theme.componentBG`)
46+
- [ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
47+
- [ ] I verified there are no new alerts related to the `canBeMissing` param for `useOnyx`
4248

4349
### UI/UX Review
4450
- [ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
@@ -65,13 +71,6 @@
6571
- [ ] All JSX used for rendering exists in the render method
6672
- [ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
6773

68-
- [ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
69-
- [ ] I verified there are no new alerts related to the `canBeMissing` param for `useOnyx`
70-
- [ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
71-
- [ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like `Avatar` is modified, I verified that `Avatar` is working as expected in all cases)
72-
- [ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
73-
- [ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like `Avatar`, I verified the components using `Avatar` have been tested & I retested again)
74-
7574
### Screenshots/Videos
7675
<details>
7776
<summary>Android: HybridApp</summary>

0 commit comments

Comments
 (0)